Skip to content

Conversation

@jlprat
Copy link
Contributor

@jlprat jlprat commented Aug 17, 2023

About this change - What it does

Resolves: #xxxxx

Why this way

@jlprat
Copy link
Contributor Author

jlprat commented Aug 17, 2023

@rdunklau Can you check if this makes sense?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #45 (5ccad44) into main (5faf30a) will decrease coverage by 1.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   90.30%   88.44%   -1.86%     
==========================================
  Files          13       13              
  Lines        1991     1991              
==========================================
- Hits         1798     1761      -37     
- Misses        193      230      +37     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants