Skip to content

Fix HTTP method casing in request events #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix HTTP method casing in request events #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/aikido/zen/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def normalized_headers

def as_json
{
method: request_method.downcase,
method: request_method,
Copy link

@aikido-pr-checks aikido-pr-checks bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed HTTP method serialization to use raw request_method (removed .downcase), introducing potential mismatch with consumers expecting lowercase method names.

Details

🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.

More info - Comment @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.

url: url,
ipAddress: client_ip,
userAgent: user_agent,
Expand Down
2 changes: 1 addition & 1 deletion test/aikido/zen/request_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module Tests
req = build_request(env)

assert_equal(
{method: "post", url: "http://example.org/test"},
{method: "POST", url: "http://example.org/test"},
req.as_json.slice(:method, :url)
)
end
Expand Down
Loading