POC for custom route patterns #837
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
tudor-timcu
reviewed
Nov 26, 2025
|
|
||
| for (const pattern of customPatterns) { | ||
| if (pattern.test(segment)) { | ||
| return `:custom`; |
There was a problem hiding this comment.
shouldn't we return the actual pattern name set by the app? eg: :tenant
| return; | ||
| } | ||
|
|
||
| if (registeredPatternsSet.has(pattern)) { |
| const NUMBER_ARRAY = /^\d+(?:,\d+)*$/; | ||
|
|
||
| export function buildRouteFromURL(url: string) { | ||
| export function buildRouteFromURL(url: string, custom: RegExp[]) { |
Member
There was a problem hiding this comment.
Make custom parameter optional and call getRegisteredRouteParams() by default, so we can still easily test but don't have to modify so many files? Only an idea, not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.