debug: CI/CD breaking config

Author: raymondwjang

.github/workflows/tests.yml

@@ -30,7 +30,7 @@ jobs:
         run: pip install -e ".[tests]"
 
       - name: Run tests with coverage
-        run: pytest --cov=cala --cov-report=xml
+        run: pytest --log-cli-level=DEBUG --cov=cala --cov-report=xml
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v4

src/cala/config.py

@@ -36,7 +36,7 @@ class LogConfig(BaseModel):
     """
     Severity for stream-based logging. If unset, use ``level``
     """
-    dir: Path = _dirs.user_log_dir
+    dir: Path = Path(_dirs.user_log_dir)
     """
     Directory where logs are stored.
     """
@@ -62,6 +62,8 @@ def uppercase_levels(cls, value: str | None = None) -> str | None:
     @field_validator("dir", mode="after")
     def create_dir(cls, value: Path) -> Path:
         value.mkdir(parents=True, exist_ok=True)
+        assert value.is_dir()
+        assert not value.is_dir()
         return value
 
 
@@ -75,6 +77,7 @@ class Config(BaseSettings, YAMLMixin):
         nested_model_default_partial_update=True,
         yaml_file="cala_config.yaml",
         pyproject_toml_table_header=("tool", "cala", "config"),
+        validate_default=True,
     )
 
     logs: LogConfig = LogConfig()

src/cala/logging.py

@@ -47,6 +47,7 @@ def init_logger(
     """
     if log_dir is None:
         log_dir = config.logs.dir
+        logging.error(f"init_logger: {log_dir}, is_dir: {log_dir.is_dir()}")
     if level is None:
         level: LOG_LEVELS = (
             config.logs.level_stdout if config.logs.level_stdout is not None else config.logs.level
@@ -115,7 +116,6 @@ def _init_root(
     stream_handlers = [
         handler for handler in root_logger.handlers if isinstance(handler, RichHandler)
     ]
-
     if log_dir is not False and not file_handlers:
         root_logger.addHandler(
             _file_handler(

tests/test_config.py

@@ -8,7 +8,7 @@ def test_config(tmp_path):
     """
     Config should be able to make directories and set sensible defaults
     """
-    config = Config(user_dir=tmp_path)
+    config = Config(user_dir=tmp_path, logs={"dir": tmp_path / "log"})
     assert config.user_dir.exists()
     assert config.logs.dir.exists()