Skip to content

Commit 702b047

Browse files
committed
chore: address feedback
1 parent 1ea4247 commit 702b047

File tree

5 files changed

+73
-112
lines changed

5 files changed

+73
-112
lines changed

.eslintrc

+4-15
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55
"plugin:jsx-a11y/recommended",
66
"plugin:@typescript-eslint/recommended",
77
"plugin:import/typescript",
8-
"plugin:react/jsx-runtime",
9-
"plugin:prettier/recommended",
10-
"prettier"
8+
"plugin:react/jsx-runtime"
119
],
1210
"env": {
13-
"node": true
11+
"node": true
1412
},
1513
"parser": "@typescript-eslint/parser",
1614
"parserOptions": {
@@ -25,8 +23,7 @@
2523
"@typescript-eslint",
2624
"import",
2725
"jsx-a11y",
28-
"react-hooks",
29-
"prettier"
26+
"react-hooks"
3027
],
3128
"rules": {
3229
"@typescript-eslint/no-explicit-any": "off",
@@ -40,15 +37,7 @@
4037
}
4138
],
4239
"react-hooks/rules-of-hooks": "error",
43-
"react-hooks/exhaustive-deps": "warn",
44-
"prettier/prettier": [
45-
"warn",
46-
{
47-
"endOfLine": "auto",
48-
"singleQuote": true,
49-
"arrowParens": "avoid"
50-
}
51-
]
40+
"react-hooks/exhaustive-deps": "warn"
5241
},
5342
"settings": {
5443
"react": {

.prettierrc

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"endOfLine": "auto",
3+
"singleQuote": true,
4+
"arrowParens": "avoid"
5+
}

package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,14 @@
2727
"@types/node": "^18.7.13",
2828
"@types/react": "^18.0.17",
2929
"@types/react-dom": "^18.0.6",
30-
"@typescript-eslint/eslint-plugin": "^5.34.0",
31-
"@typescript-eslint/parser": "^5.34.0",
30+
"@typescript-eslint/eslint-plugin": "^5.35.1",
31+
"@typescript-eslint/parser": "^5.35.1",
3232
"@vitejs/plugin-react": "^2.0.1",
3333
"autoprefixer": "^10.4.8",
3434
"clsx": "^1.2.1",
3535
"eslint": "^8.22.0",
36-
"eslint-config-prettier": "^8.5.0",
3736
"eslint-plugin-import": "^2.26.0",
3837
"eslint-plugin-jsx-a11y": "^6.6.1",
39-
"eslint-plugin-prettier": "^4.2.1",
4038
"eslint-plugin-react": "^7.30.1",
4139
"eslint-plugin-react-hooks": "^4.6.0",
4240
"framer-motion": "^7.2.1",

src/App.tsx

+13-20
Original file line numberDiff line numberDiff line change
@@ -23,28 +23,20 @@ const watchPurses = async (
2323
const n = await E(wallet).getPursesNotifier();
2424
for await (const purses of iterateNotifier(n)) {
2525
setPurses(purses);
26-
purses.forEach(
27-
({
28-
brand,
29-
displayInfo,
30-
brandPetname: petname,
31-
}: {
32-
brand: any;
33-
displayInfo: any;
34-
brandPetname: string;
35-
}) => {
36-
const decimalPlaces = displayInfo && displayInfo.decimalPlaces;
37-
const assetKind = displayInfo && displayInfo.assetKind;
3826

39-
const newInfo = {
40-
petname,
41-
assetKind,
42-
decimalPlaces,
43-
};
27+
for (const purse of purses) {
28+
const { brand, displayInfo, brandPetname: petname } = purse;
29+
const decimalPlaces = displayInfo && displayInfo.decimalPlaces;
30+
const assetKind = displayInfo && displayInfo.assetKind;
4431

45-
mergeBrandToInfo([[brand, newInfo]]);
46-
}
47-
);
32+
const newInfo = {
33+
petname,
34+
assetKind,
35+
decimalPlaces,
36+
};
37+
38+
mergeBrandToInfo([[brand, newInfo]]);
39+
}
4840
}
4941
};
5042

@@ -64,6 +56,7 @@ const App = () => {
6456
useEffect(() => {
6557
if (wallet === null) return;
6658

59+
// TODO: More user-friendly error handling, like a toast.
6760
watchPurses(wallet, setPurses, mergeBrandToInfo).catch((err: Error) =>
6861
console.error('got watchPurses err', err)
6962
);

yarn.lock

+49-73
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141

4242
"@agoric/wallet@^0.13.1":
4343
version "0.13.1"
44-
resolved "https://registry.npmjs.org/@agoric/wallet/-/wallet-0.13.1.tgz"
44+
resolved "https://registry.yarnpkg.com/@agoric/wallet/-/wallet-0.13.1.tgz#965466c552bea7a63dabba4bafc2b19881716095"
4545
integrity sha512-5j8RuO9mMhBBidp90So2vVSsRzhejz09iPutm/wD0NNuOtZ2Y0HrMyPWyq4A5pxrLw7xWH/W+LwKwJUmBlAQyQ==
4646
dependencies:
4747
agoric "^0.16.0"
@@ -751,84 +751,84 @@
751751
resolved "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.2.tgz"
752752
integrity sha512-hppQEBDmlwhFAXKJX2KnWLYu5yMfi91yazPb2l+lbJiwW+wdo1gNeRA+3RgNSO39WYX2euey41KEwnqesU2Jew==
753753

754-
"@typescript-eslint/eslint-plugin@^5.34.0":
755-
version "5.34.0"
756-
resolved "https://registry.npmjs.org/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.34.0.tgz"
757-
integrity sha512-eRfPPcasO39iwjlUAMtjeueRGuIrW3TQ9WseIDl7i5UWuFbf83yYaU7YPs4j8+4CxUMIsj1k+4kV+E+G+6ypDQ==
754+
"@typescript-eslint/eslint-plugin@^5.35.1":
755+
version "5.35.1"
756+
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.35.1.tgz#0d822bfea7469904dfc1bb8f13cabd362b967c93"
757+
integrity sha512-RBZZXZlI4XCY4Wzgy64vB+0slT9+yAPQRjj/HSaRwUot33xbDjF1oN9BLwOLTewoOI0jothIltZRe9uJCHf8gg==
758758
dependencies:
759-
"@typescript-eslint/scope-manager" "5.34.0"
760-
"@typescript-eslint/type-utils" "5.34.0"
761-
"@typescript-eslint/utils" "5.34.0"
759+
"@typescript-eslint/scope-manager" "5.35.1"
760+
"@typescript-eslint/type-utils" "5.35.1"
761+
"@typescript-eslint/utils" "5.35.1"
762762
debug "^4.3.4"
763763
functional-red-black-tree "^1.0.1"
764764
ignore "^5.2.0"
765765
regexpp "^3.2.0"
766766
semver "^7.3.7"
767767
tsutils "^3.21.0"
768768

769-
"@typescript-eslint/parser@^5.34.0":
770-
version "5.34.0"
771-
resolved "https://registry.npmjs.org/@typescript-eslint/parser/-/parser-5.34.0.tgz"
772-
integrity sha512-SZ3NEnK4usd2CXkoV3jPa/vo1mWX1fqRyIVUQZR4As1vyp4fneknBNJj+OFtV8WAVgGf+rOHMSqQbs2Qn3nFZQ==
769+
"@typescript-eslint/parser@^5.35.1":
770+
version "5.35.1"
771+
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.35.1.tgz#bf2ee2ebeaa0a0567213748243fb4eec2857f04f"
772+
integrity sha512-XL2TBTSrh3yWAsMYpKseBYTVpvudNf69rPOWXWVBI08My2JVT5jR66eTt4IgQFHA/giiKJW5dUD4x/ZviCKyGg==
773773
dependencies:
774-
"@typescript-eslint/scope-manager" "5.34.0"
775-
"@typescript-eslint/types" "5.34.0"
776-
"@typescript-eslint/typescript-estree" "5.34.0"
774+
"@typescript-eslint/scope-manager" "5.35.1"
775+
"@typescript-eslint/types" "5.35.1"
776+
"@typescript-eslint/typescript-estree" "5.35.1"
777777
debug "^4.3.4"
778778

779-
"@typescript-eslint/scope-manager@5.34.0":
780-
version "5.34.0"
781-
resolved "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-5.34.0.tgz"
782-
integrity sha512-HNvASMQlah5RsBW6L6c7IJ0vsm+8Sope/wu5sEAf7joJYWNb1LDbJipzmdhdUOnfrDFE6LR1j57x1EYVxrY4ow==
779+
"@typescript-eslint/scope-manager@5.35.1":
780+
version "5.35.1"
781+
resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-5.35.1.tgz#ccb69d54b7fd0f2d0226a11a75a8f311f525ff9e"
782+
integrity sha512-kCYRSAzIW9ByEIzmzGHE50NGAvAP3wFTaZevgWva7GpquDyFPFcmvVkFJGWJJktg/hLwmys/FZwqM9EKr2u24Q==
783783
dependencies:
784-
"@typescript-eslint/types" "5.34.0"
785-
"@typescript-eslint/visitor-keys" "5.34.0"
784+
"@typescript-eslint/types" "5.35.1"
785+
"@typescript-eslint/visitor-keys" "5.35.1"
786786

787-
"@typescript-eslint/type-utils@5.34.0":
788-
version "5.34.0"
789-
resolved "https://registry.npmjs.org/@typescript-eslint/type-utils/-/type-utils-5.34.0.tgz"
790-
integrity sha512-Pxlno9bjsQ7hs1pdWRUv9aJijGYPYsHpwMeCQ/Inavhym3/XaKt1ZKAA8FIw4odTBfowBdZJDMxf2aavyMDkLg==
787+
"@typescript-eslint/type-utils@5.35.1":
788+
version "5.35.1"
789+
resolved "https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-5.35.1.tgz#d50903b56758c5c8fc3be52b3be40569f27f9c4a"
790+
integrity sha512-8xT8ljvo43Mp7BiTn1vxLXkjpw8wS4oAc00hMSB4L1/jIiYbjjnc3Qp2GAUOG/v8zsNCd1qwcqfCQ0BuishHkw==
791791
dependencies:
792-
"@typescript-eslint/utils" "5.34.0"
792+
"@typescript-eslint/utils" "5.35.1"
793793
debug "^4.3.4"
794794
tsutils "^3.21.0"
795795

796-
"@typescript-eslint/types@5.34.0":
797-
version "5.34.0"
798-
resolved "https://registry.npmjs.org/@typescript-eslint/types/-/types-5.34.0.tgz"
799-
integrity sha512-49fm3xbbUPuzBIOcy2CDpYWqy/X7VBkxVN+DC21e0zIm3+61Z0NZi6J9mqPmSW1BDVk9FIOvuCFyUPjXz93sjA==
796+
"@typescript-eslint/types@5.35.1":
797+
version "5.35.1"
798+
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-5.35.1.tgz#af355fe52a0cc88301e889bc4ada72f279b63d61"
799+
integrity sha512-FDaujtsH07VHzG0gQ6NDkVVhi1+rhq0qEvzHdJAQjysN+LHDCKDKCBRlZFFE0ec0jKxiv0hN63SNfExy0KrbQQ==
800800

801-
"@typescript-eslint/typescript-estree@5.34.0":
802-
version "5.34.0"
803-
resolved "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-5.34.0.tgz"
804-
integrity sha512-mXHAqapJJDVzxauEkfJI96j3D10sd567LlqroyCeJaHnu42sDbjxotGb3XFtGPYKPD9IyLjhsoULML1oI3M86A==
801+
"@typescript-eslint/typescript-estree@5.35.1":
802+
version "5.35.1"
803+
resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-5.35.1.tgz#db878a39a0dbdc9bb133f11cdad451770bfba211"
804+
integrity sha512-JUqE1+VRTGyoXlDWWjm6MdfpBYVq+hixytrv1oyjYIBEOZhBCwtpp5ZSvBt4wIA1MKWlnaC2UXl2XmYGC3BoQA==
805805
dependencies:
806-
"@typescript-eslint/types" "5.34.0"
807-
"@typescript-eslint/visitor-keys" "5.34.0"
806+
"@typescript-eslint/types" "5.35.1"
807+
"@typescript-eslint/visitor-keys" "5.35.1"
808808
debug "^4.3.4"
809809
globby "^11.1.0"
810810
is-glob "^4.0.3"
811811
semver "^7.3.7"
812812
tsutils "^3.21.0"
813813

814-
"@typescript-eslint/utils@5.34.0":
815-
version "5.34.0"
816-
resolved "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-5.34.0.tgz"
817-
integrity sha512-kWRYybU4Rn++7lm9yu8pbuydRyQsHRoBDIo11k7eqBWTldN4xUdVUMCsHBiE7aoEkFzrUEaZy3iH477vr4xHAQ==
814+
"@typescript-eslint/utils@5.35.1":
815+
version "5.35.1"
816+
resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.35.1.tgz#ae1399afbfd6aa7d0ed1b7d941e9758d950250eb"
817+
integrity sha512-v6F8JNXgeBWI4pzZn36hT2HXXzoBBBJuOYvoQiaQaEEjdi5STzux3Yj8v7ODIpx36i/5s8TdzuQ54TPc5AITQQ==
818818
dependencies:
819819
"@types/json-schema" "^7.0.9"
820-
"@typescript-eslint/scope-manager" "5.34.0"
821-
"@typescript-eslint/types" "5.34.0"
822-
"@typescript-eslint/typescript-estree" "5.34.0"
820+
"@typescript-eslint/scope-manager" "5.35.1"
821+
"@typescript-eslint/types" "5.35.1"
822+
"@typescript-eslint/typescript-estree" "5.35.1"
823823
eslint-scope "^5.1.1"
824824
eslint-utils "^3.0.0"
825825

826-
"@typescript-eslint/visitor-keys@5.34.0":
827-
version "5.34.0"
828-
resolved "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-5.34.0.tgz"
829-
integrity sha512-O1moYjOSrab0a2fUvFpsJe0QHtvTC+cR+ovYpgKrAVXzqQyc74mv76TgY6z+aEtjQE2vgZux3CQVtGryqdcOAw==
826+
"@typescript-eslint/visitor-keys@5.35.1":
827+
version "5.35.1"
828+
resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-5.35.1.tgz#285e9e34aed7c876f16ff646a3984010035898e6"
829+
integrity sha512-cEB1DvBVo1bxbW/S5axbGPE6b7FIMAbo3w+AGq6zNDA7+NYJOIkKj/sInfTv4edxd4PxJSgdN4t6/pbvgA+n5g==
830830
dependencies:
831-
"@typescript-eslint/types" "5.34.0"
831+
"@typescript-eslint/types" "5.35.1"
832832
eslint-visitor-keys "^3.3.0"
833833

834834
"@vitejs/plugin-react@^2.0.1":
@@ -1605,11 +1605,6 @@ escape-string-regexp@^4.0.0:
16051605
resolved "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz"
16061606
integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==
16071607

1608-
eslint-config-prettier@^8.5.0:
1609-
version "8.5.0"
1610-
resolved "https://registry.npmjs.org/eslint-config-prettier/-/eslint-config-prettier-8.5.0.tgz"
1611-
integrity sha512-obmWKLUNCnhtQRKc+tmnYuQl0pFU1ibYJQ5BGhTVB08bHe9wC8qUeG7c08dj9XX+AuPj1YSGSQIHl1pnDHZR0Q==
1612-
16131608
eslint-import-resolver-node@^0.3.6:
16141609
version "0.3.6"
16151610
resolved "https://registry.npmjs.org/eslint-import-resolver-node/-/eslint-import-resolver-node-0.3.6.tgz"
@@ -1671,13 +1666,6 @@ eslint-plugin-jsx-a11y@^6.6.1:
16711666
minimatch "^3.1.2"
16721667
semver "^6.3.0"
16731668

1674-
eslint-plugin-prettier@^4.2.1:
1675-
version "4.2.1"
1676-
resolved "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz"
1677-
integrity sha512-f/0rXLXUt0oFYs8ra4w49wYZBG5GKZpAYsJSm6rnYL5uVDjd+zowwMwVZHnAjf4edNrKpCDYfXDgmRE/Ak7QyQ==
1678-
dependencies:
1679-
prettier-linter-helpers "^1.0.0"
1680-
16811669
eslint-plugin-react-hooks@^4.6.0:
16821670
version "4.6.0"
16831671
resolved "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-4.6.0.tgz"
@@ -1852,11 +1840,6 @@ fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
18521840
resolved "https://registry.npmjs.org/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz"
18531841
integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==
18541842

1855-
fast-diff@^1.1.2:
1856-
version "1.2.0"
1857-
resolved "https://registry.npmjs.org/fast-diff/-/fast-diff-1.2.0.tgz"
1858-
integrity sha512-xJuoT5+L99XlZ8twedaRf6Ax2TgQVxvgZOYoPKqZufmJib0tL2tegPBOZb1pVNgIhlqDlA0eO0c3wBvQcmzx4w==
1859-
18601843
fast-glob@^3.2.11, fast-glob@^3.2.9:
18611844
version "3.2.11"
18621845
resolved "https://registry.npmjs.org/fast-glob/-/fast-glob-3.2.11.tgz"
@@ -2820,16 +2803,9 @@ prelude-ls@^1.2.1:
28202803
resolved "https://registry.npmjs.org/prelude-ls/-/prelude-ls-1.2.1.tgz"
28212804
integrity sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g==
28222805

2823-
prettier-linter-helpers@^1.0.0:
2824-
version "1.0.0"
2825-
resolved "https://registry.npmjs.org/prettier-linter-helpers/-/prettier-linter-helpers-1.0.0.tgz"
2826-
integrity sha512-GbK2cP9nraSSUF9N2XwUwqfzlAFlMNYYl+ShE/V+H8a9uNl/oUqB1w2EL54Jh0OlyRSd8RfWYJ3coVS4TROP2w==
2827-
dependencies:
2828-
fast-diff "^1.1.2"
2829-
28302806
prettier@^2.7.1:
28312807
version "2.7.1"
2832-
resolved "https://registry.npmjs.org/prettier/-/prettier-2.7.1.tgz"
2808+
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.7.1.tgz#e235806850d057f97bb08368a4f7d899f7760c64"
28332809
integrity sha512-ujppO+MkdPqoVINuDFDRLClm7D78qbDt0/NR+wp5FqEZOoTNAjPHWj17QRhu7geIHJfcNhRk1XVQmF8Bp3ye+g==
28342810

28352811
prop-types@^15.8.1:

0 commit comments

Comments
 (0)