Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to manage contract / UI API consistency? #47

Open
dckc opened this issue Jan 23, 2024 · 0 comments
Open

how to manage contract / UI API consistency? #47

dckc opened this issue Jan 23, 2024 · 0 comments

Comments

@dckc
Copy link
Member

dckc commented Jan 23, 2024

  • names like Place, Places, makeTradeInvitation should have a single source of truth; e.g. a client API module
    • changing want.Places to want[KW.Places] in the contract would make it harder to read
    • maybe unit tests suffice to ensure consistency between the client API and the contract??

Both the contract and the ui should have tests of the interface between them. I think the contract has one. I don't think the UI does.

cc @0xpatrickdev @samsiegart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dckc