You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Deploying the contract is a bit fragile (e.g. #60). Changes like #61 could easily break it.
Let's have each change tested by the bots to make sure that deploying the contract isn't broken.
design sketch: using an a3p integration test a la cosgov
Idea: keep this worked scoped to an a3p style test. It should include:
Install Bundles
CoreEval Proposal
Verify Instance is in agoricNames.instance (agd.query)
Submit agd.tx('swingset wallet-action ...') to buy an Item.
There seems like there could be overlap with thoughts here - the current .sh scripts we use could be node scripts which are easier to test (and our developer community to grok). (Much of the logic we need is already in @agoric/synthetic-chain/../commonUpgradeHelper.js)
Separately:
chainStorageWatcher integration test to ensure instance, purses can be retrieved (would've caught the regression in fix: wallet connection and chainStorageWatcher #63, but not sufficient to test the walletConnection flow)
E2E with Keplr using something like dappeteer (requires a keplr plugin to be built)
Edit: this is maybe want dan already means, outside of the increased scope suggestion to refactor /scripts/*, but "a la cosgov" currnetly just means queries against the 1317 endpoint.
Deploying the contract is a bit fragile (e.g. #60). Changes like #61 could easily break it.
Let's have each change tested by the bots to make sure that deploying the contract isn't broken.
design sketch: using an a3p integration test a la cosgov
cc @0xpatrickdev
The text was updated successfully, but these errors were encountered: