Skip to content

Commit

Permalink
"Change Optional[T] to T, update VERSION to 0.24.2, update CHANGELOG" (
Browse files Browse the repository at this point in the history
…#89)

* "Change Optional[T] to T, update VERSION to 0.24.2, update CHANGELOG"

* Update version to 0.24.3, fetch upstream
  • Loading branch information
sayandipdutta authored Feb 4, 2022
1 parent ddea4c2 commit 9e5bcd5
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.24.3] - 2022-02-04

### Changed

- Typing: Use `bool` in place of `Optional[bool]` as type annotation for `develop` parameter in `covalent_dispatcher.service._graceful_start`
- Typing: Use `Any` in place of `Optional[Any]` as type annotation for `new_value` parameter in `covalent._shared_files.config.get_config`

## [0.24.2] - 2022-02-04

Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.24.2
0.24.3
4 changes: 2 additions & 2 deletions covalent/_shared_files/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from functools import reduce
from operator import getitem
from pathlib import Path
from typing import Any, Dict, List, Optional, Union
from typing import Any, Dict, List, Union

import toml

Expand Down Expand Up @@ -145,7 +145,7 @@ def set(self, key: str, value: Any) -> None:
_config_manager = _ConfigManager()


def set_config(new_config: Union[Dict, str], new_value: Optional[Any] = None) -> None:
def set_config(new_config: Union[Dict, str], new_value: Any = None) -> None:
"""
Update the configuration.
Expand Down
3 changes: 1 addition & 2 deletions covalent_dispatcher/_cli/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import signal
import socket
from subprocess import Popen
from typing import Optional

import click
import psutil
Expand Down Expand Up @@ -157,7 +156,7 @@ def _graceful_start(
pidfile: str,
logfile: str,
port: int,
develop: Optional[bool] = False,
develop: bool = False,
) -> int:
"""
Gracefully start a Flask app with gunicorn.
Expand Down

0 comments on commit 9e5bcd5

Please sign in to comment.