cli: Recommend XFS over f2fs and ext4

Note that, in addition to being slow for cold blits, ext4 only supports
65k hardlinks per file, and it has a limit of 4k for combined extended
attribute data as well.

Given we are looking at supporting SELinux, there is a very real chance
that we are artificially (and knowingly) limiting ourselves by offering
ext4 as a rootfs for Serpent OS.

NB: AerynOS/recipes#548 is now up as a way to
    help mitigate the ext4 and f2fs cold blit slowness until we figure
    out a better solution.

Signed-off-by: Rune Morling <[email protected]>

Author: ermo

lichen_cli/src/main.rs

@@ -122,9 +122,13 @@ fn ask_rootfs(parts: &[SystemPartition]) -> color_eyre::Result<&SystemPartition>
 
 fn ask_filesystem() -> color_eyre::Result<String> {
     let variants = [
-        ("xfs", "XFS", "For reliability (journaling)"),
-        ("f2fs", "F2FS", "For flash storage (speed)"),
-        ("ext4", "Ext4", "Not recommended due to small hardlink limit"),
+        ("xfs", "XFS", "Recommended (fast with moss, reliable)"),
+        ("f2fs", "F2FS", "Not Recommended (slow with moss)"),
+        (
+            "ext4",
+            "EXT4",
+            "Not Recommended (slow with moss, limited number of rollbacks supported)",
+        ),
     ];
     let index = cliclack::select("Pick a filesystem for your rootfs")
         .items(&variants)