Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS Commons Redirect Manager - Publication issue #3516

Open
sabdouni opened this issue Jan 30, 2025 · 2 comments
Open

ACS Commons Redirect Manager - Publication issue #3516

sabdouni opened this issue Jan 30, 2025 · 2 comments
Assignees

Comments

@sabdouni
Copy link

sabdouni commented Jan 30, 2025

Technical Env:

  • AEM Cloud SDK : aem-sdk-quickstart-2025.1.19149.20250116T154450Z-241100.jar
  • ACS Commons : 6.10.0

Issue:
We noticed an issue with the Redirect Manager, when redirect rows are created using the file import they are not published to the publisher when running the 'Publish Redirect Configurations' button.

We also noticed a difference between those created via file import and those created directly from the form:

  • When created via the file import, each redirect row has a jcr:primaryType of type sling:Folder
  • When created via the form, each redirect row has a jcr:primaryType of type nt:unstructured

This difference is causing an issue with the 'Publish Redirect Configurations', mainly on the JSP /apps/acs-commons/components/utilities/manage-redirects/replicate.POST.jsp, only the redirect rows created manually ( jcr:primaryType of type nt:unstructured) are replicated

2 possible solutions:

  • Update the code of /apps/acs-commons/components/utilities/manage-redirects/replicate.POST.jsp
  • Handle redirect rows created manually & with Excel import in the same way (meaning create redirect rows with jcr:primaryType=type nt:unstructured)

I think the last solution is cleaner.

I can provide a PR if my analysis is correct.

Thanks

@sabdouni
Copy link
Author

A proposition of fix here #3517

@YegorKozlov
Copy link
Contributor

@sabdouni thanks for the PR. It was a regression which is addressed in
#3504
and
#3503

these two should go in v6.11

@YegorKozlov YegorKozlov self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants