Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mode to generate queueUrl from incoming request, rather than static hostname. #219

Open
nhoughto opened this issue Mar 4, 2020 · 3 comments

Comments

@nhoughto
Copy link

nhoughto commented Mar 4, 2020

The current behaviour as I understand it is to configure a static hostname (or allow it to default to localhost) and then that value is used to create the queueUrl that clients will follow to do SQS ReceiveMessage etc.

This works in simple situations but breaks scenarios where a single goaws instance might have multiple ingress paths, think Kubernetes Service vs Kubernetes Ingress vs Kubernetes NodePort.. there are lots of reasons this can happen.

To solve this problem it would be great if you could configure a mode where the hostname used in the queueUrl is derived from the incoming request rather than from configuration or defaulted. This limits the number of "environments" you can have, I expect you can only have 1 in "derive" mode, but i'd expect most users have just one environment anyway.

@nhoughto
Copy link
Author

nhoughto commented Mar 4, 2020

Seems to be mostly solved by #213
That appears to be changing the default behavour from localhost to using the host header tho, which is possibly undesirable.

I made an alternative version of the fix too here:

bsycorp@2f32176

@p4tin
Copy link
Collaborator

p4tin commented Apr 18, 2020

PR?

@nhoughto
Copy link
Author

way late 😬
#234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants