Statistics do not add up or match upstream logs

[timkgh]

Prerequisites

• I have checked the Wiki and Discussions and found no answer

• I have searched other issues and found no duplicates

• I want to report a bug and not ask a question or ask for help

• I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

Linux, MIPS64 LE

Installation

GitHub releases or script from README

Setup

On a router, DHCP is handled by the router

AdGuard Home version

v0.108.0-b.62

Action

• General stats over past 30 days show 2.1M requests.
• Top upstreams are way off and they don't match the stats from the upstreams, e.g. ControlD as reported by AGH shows 162K requests, but looking at the actual ControlD stats on their side, there were 1.4M requests over the past month. This is ~10x difference.

I do have optimistic caching and parallel requests enabled in AGH, but still the stats for top upstreams are way off and they don't match the actual requests seen by the upstream.

Not sure whether there is a reasonable explanation for this or a bug where it is literally off by a factor of 10?

First 192.168 upstream below is the local LAN DHCP+DNS server that only serves requests for the local LAN domain.

ControlD Stats:

Expected result

Stats should match (within some small margin of error).

Actual result

Stats do not match actual requests seen by the upstreams, they are way off by ~10x.

Additional information and/or screenshots

No response

[schzhn]

It is most likely due to a combination of caching and the Parallel requests mode.

[timkgh]

Alright, I'll turn off parallel requests but I have to leave caching on. Let's see what happens to the stats now.

[timkgh]

Even with parallel requests off, the stats are still way off. And it is not that the responses are cached because the requests do make it to the upstreams, I can see them in the upstream logs.

It looks like proper accounting for upstream requests needs some work.