Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Statistic comma format the numbers #7329

Closed
3 tasks done
melucas opened this issue Oct 6, 2024 · 4 comments
Closed
3 tasks done

General Statistic comma format the numbers #7329

melucas opened this issue Oct 6, 2024 · 4 comments

Comments

@melucas
Copy link

melucas commented Oct 6, 2024

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

On the Dashboard page (index) in the General Statistics section, could you please format the numbers with a comma (thousand separator) for the items in the list.

See the yellow highlighted numbers in the screen capture attached.

Screen

Proposed solution

Format the number using the same formatting as the Top Clients and Top Domains counts.

The values are formatted in the HTML which looks like it will require some backend changes to the main.js.

Alternatives considered and additional information

No response

@handcoding
Copy link

handcoding commented Jan 23, 2025

@ainar-g @bniwredyc While I very much appreciate this commit—which certainly helps!—I had also wanted to ask whether it might be possible to implement this same fix for thousands separators for the dashboard’s Average upstream response time table, such as shown below?

Image

@ainar-g
Copy link
Contributor

ainar-g commented Jan 23, 2025

@handcoding, it's a reasonable improvement, yeah, but please open a new issue about it.

@handcoding
Copy link

@handcoding, it's a reasonable improvement, yeah, but please open a new issue about it.

@ainar-g Sounds good! I’ve filed that as issue #7590.

@melucas
Copy link
Author

melucas commented Jan 24, 2025

Thank you for including the General Statistics fix in the latest release build. Working as expected on my 2 instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants