Fix duplicating sources in non-aggregate projects

When extended project has package Naming with a naming exception
for a particular unit, extending project does not have project
Naming declared and source dirs of both projects have file
that corresponds to that naming exception, Source_Files returned
both of those files, thus creating a duplicate base name
in a non-aggregate project.
Ignore files that have Replaced_By set to illiminate duplicates.

Change-Id: I92102bc73dea352aad1788fbc19a56d05c8161dd
TN: U715-007

Author: fedor-rybin

src/gnatcoll-projects.adb

@@ -9901,6 +9901,15 @@ package body GNATCOLL.Projects is
             Source := Element (Source_Iter);
             exit when Source = No_Source;
 
+            if Source.Replaced_By /= No_Source then
+               --  In case of extending project inheriting package Naming of
+               --  the extended one and source dirs of both projects containing
+               --  same naming exception source, we will get a duplicate base
+               --  name outside of aggregate project here which is not allowed.
+               --  The replaced source needs to be ignored.
+               goto Next_Source;
+            end if;
+
             --  Get the absolute path name for this source
 
             Get_Name_String (Source.Path.Display_Name);
@@ -10009,6 +10018,7 @@ package body GNATCOLL.Projects is
                end if;
             end;
 
+            <<Next_Source>>
             Next (Source_Iter);
          end loop;
 

testsuite/tests/projects/custom_name_duplicate/p.gpr

@@ -0,0 +1,2 @@
+project P extends "q/q.gpr" is
+end P;

testsuite/tests/projects/custom_name_duplicate/pack.ads_foo

@@ -0,0 +1,2 @@
+package Pack is
+end Pack;

testsuite/tests/projects/custom_name_duplicate/pack2.ads

@@ -0,0 +1,2 @@
+package Pack2 is
+end Pack2;

testsuite/tests/projects/custom_name_duplicate/q/pack.ads_foo

@@ -0,0 +1,2 @@
+package Pack is
+end Pack;

testsuite/tests/projects/custom_name_duplicate/q/pack2.ads

@@ -0,0 +1,2 @@
+package Pack2 is
+end Pack2;

testsuite/tests/projects/custom_name_duplicate/q/q.gpr

@@ -0,0 +1,5 @@
+project Q is
+   package Naming is
+      for Spec ("Pack") use "pack.ads_foo";
+   end Naming;
+end Q;

testsuite/tests/projects/custom_name_duplicate/test.adb

@@ -0,0 +1,41 @@
+with GNATCOLL.Projects; use GNATCOLL.Projects;
+with GNATCOLL.Projects.Aux;
+with GNATCOLL.VFS;      use GNATCOLL.VFS;
+with Test_Assert;
+
+with Ada.Containers.Indefinite_Ordered_Sets;
+
+function Test return Integer is
+   PT : Project_Tree;
+   Env : Project_Environment_Access;
+
+   Files : File_Array_Access;
+
+   package Sets is new Ada.Containers.Indefinite_Ordered_Sets (String);
+   use Sets;
+
+   Set : Sets.Set;
+begin
+   Initialize (Env);
+   PT.Load (GNATCOLL.VFS.Create ("p.gpr"), Env);
+
+   Files := PT.Root_Project.Source_Files (Recursive => True);
+
+   for F of Files.all loop
+      if Set.Contains (F.Display_Base_Name) then
+         Test_Assert.Assert
+           (False, "duplicating source: " & F.Display_Base_Name);
+      else
+         Set.Insert (F.Display_Base_Name);
+      end if;
+   end loop;
+
+   Unchecked_Free (Files);
+
+   Set.Clear;
+   GNATCOLL.Projects.Aux.Delete_All_Temp_Files (PT.Root_Project);
+   Unload (PT);
+   Free (Env);
+
+   return Test_Assert.Report;
+end Test;

testsuite/tests/projects/custom_name_duplicate/test.yaml

@@ -0,0 +1,11 @@
+description: >
+  Check that when extending project has no package Naming
+  but extended one does and source dirs of both projects
+  have the same naming exception source Source_Files returns
+  only one of those sources and not both.
+data:
+    - "test.adb"
+    - "p.gpr"
+    - "pack.ads_foo"
+    - "pack2.ads"
+    - "q"