diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..6a8cc19f5 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,3 +1,4 @@ +from dotenv import load_dotenv from flask import Flask from flask_sqlalchemy import SQLAlchemy from flask_migrate import Migrate @@ -29,6 +30,13 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) + # Register Blueprints here + from app.models.task import Task + from .routes.routes import task_bp, goals_bp + + app.register_blueprint(task_bp) + app.register_blueprint(goals_bp) + return app diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..ec0a129a8 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,36 @@ from app import db +from flask import Blueprint, make_response, request, jsonify, abort, request + class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + tasks = db.relationship("Task", back_populates="goal") + + def to_dict(self): + return { + "title": self.title, + "id": self.goal_id + } + + @classmethod + def from_json(cls, req_body): + return cls( + title=req_body['title'] + ) + + def update(self,req_body): + try: + self.title = req_body["title"] + except KeyError as error: + abort(make_response({'message': f"Missing attribute: {error}"})) + + def to_new_dict(self): + return { + "title": self.title, + "description": self.description, + "is_complete": self.completed_at != None, + "id": self.task_id, + "goal_id": self.goal_id + } diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..6804ad750 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,50 @@ from app import db +from flask import Blueprint, make_response, request, jsonify, abort, request class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, default=None) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id')) + goal = db.relationship("Goal", back_populates="tasks") + + def to_dict(self): + return { + "title": self.title, + "description": self.description, + "is_complete": self.completed_at != None, + "id": self.task_id + } + + @classmethod + def from_json(cls, req_body): + return cls( + title=req_body['title'], + description=req_body['description'], + #TODO completed_at=req_body['completed_at'] + ) + + def update(self,req_body): + try: + self.title = req_body["title"] + self.description = req_body["description"] + self.completed_at = req_body["completed_at"] + except KeyError as error: + abort(make_response({'message': f"Missing attribute: {error}"})) + + def __str__(self): + return "Task" + + def __repr__(self): + return "Task" + + def to_new_dict(self): + return { + "title": self.title, + "description": self.description, + "is_complete": self.completed_at != None, + "id": self.task_id, + "goal_id": self.goal_id + } diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/routes/routes.py b/app/routes/routes.py new file mode 100644 index 000000000..a1baa6cf6 --- /dev/null +++ b/app/routes/routes.py @@ -0,0 +1,237 @@ +from flask import Blueprint, make_response, request, jsonify, abort +from app import db +from app.models.task import Task +from datetime import datetime +from app.models.goal import Goal +import os, requests + +#VALIDATE ID +def validate_id(class_obj,id): + try: + id = int(id) + except: + abort(make_response({"message":f"{id} is an invalid id"}, 400)) + query_result = class_obj.query.get(id) + if not query_result: + abort(make_response({"message":f"{id} not found"}, 404)) + + return query_result + +#CREATE TASK +task_bp = Blueprint("Task", __name__, url_prefix="/tasks") +@task_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + if "title" not in request_body or "description" not in request_body: + #TODO later wave will need 'or "completed_at" not in request_body', add above + return make_response({"details": "Invalid data"}, 400) + + new_task = Task.from_json(request_body) + + # abort(make_response) + db.session.add(new_task) + db.session.commit() + response_body = { + "task": new_task.to_dict() + } + return make_response(response_body, 201) + +# @task_bp.route("", methods=["GET"]) +# def read_all_task(): +# tasks_response = [] +# tasks = Task.query.all() +# for task in tasks: +# tasks_response.append(task.to_dict()) +# return jsonify(tasks_response) +##GET ALL TASKS AND SORT TASKS BY ASC & DESC + +@task_bp.route("", methods=["GET"]) +def read_all_task(): + title_sort_query = request.args.get("sort") + if title_sort_query == "asc": + tasks = Task.query.order_by(Task.title.asc()) + elif title_sort_query == "desc": + tasks = Task.query.order_by(Task.title.desc()) + else: + tasks = Task.query.all() + + response = [] + for task in tasks: + response.append(task.to_dict()) + return jsonify(response) + +#GET ONE TASK +@task_bp.route("/", methods=["GET"]) +def get_one_task(task_id): + task = validate_id(Task, task_id) + if task.goal_id is None: + return {"task": task.to_dict()} + else: + return {"task": task.to_new_dict()} + # response_body = { + # "task": task.to_dict() + # } + # return response_body + +#UPDATE TASK +@task_bp.route("/", methods=["PUT"]) +def update_task(task_id): + task = validate_id(Task, task_id) + request_body = request.get_json() + task.title = request_body["title"] + task.description = request_body["description"] + # TODO task.completed_at = request_body["completed_at"] #include later + # task.update(request_body) + db.session.commit() + response_body = { + "task": task.to_dict() + } + return make_response(response_body, 200) + +#DELETE ONE TASK +@task_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + task = validate_id(Task, task_id) + + task_dict = task.to_dict() + + db.session.delete(task) + db.session.commit() + + return { + "details": f'Task {task_id} "{task_dict["title"]}" successfully deleted'} + +#MARK COMPLETE +#MODIFY MARK COMPLETE TO CALL SLACK API +@task_bp.route("//mark_complete", methods=["PATCH"]) #custom endpoint mark task complete +def mark_complete(task_id): + task = validate_id(Task, task_id) + task.completed_at = datetime.utcnow() + + db.session.commit() + response = { + "task": task.to_dict() + } + slack_key = os.environ.get("SLACKBOT_API_KEY") + path = "https://slack.com/api/chat.postMessage" + data = { + "channel": "task-notifications", + "text": f"Someone just completed the task {task.title}" + } + headers = { + "authorization":f"Bearer {slack_key}" + } + return jsonify(response) + + +#MARK INCOMPLETE +@task_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_incomplete(task_id): + task = validate_id(Task, task_id) + task.completed_at = None + + db.session.commit() + response = { + "task": task.to_dict() + } + + return jsonify(response) + +### GOAL ROUTES +#POST/CREATE A GOAL +goals_bp = Blueprint("Goal", __name__, url_prefix="/goals") +@goals_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + if "title" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + new_goal = Goal(title=request_body["title"]) + + #abort(make_response) + db.session.add(new_goal) + db.session.commit() + + response_body = { + "goal": new_goal.to_dict() + } + return make_response(response_body), 201 + +#POST # +@goals_bp.route("//tasks", methods=["POST"]) +def post_tasks_to_goal(goal_id): + goal = validate_id(Goal, goal_id) + + request_body = request.get_json() + task_ids = [] + + for task_id in request_body["task_ids"]: + task = validate_id(Task, task_id) + + goal.tasks.append(task) + task_ids.append(task_id) + + db.session.commit() + + return {"id": goal.goal_id, "task_ids": task_ids} + +@goals_bp.route("//tasks", methods=["GET"]) +def get_tasks_with_goal(goal_id): + goal = validate_id(Goal, goal_id) + + response = [] + + for task in goal.tasks: + response.append(task.to_new_dict()) + + return {"id": goal.goal_id, "title": goal.title, "tasks": response} + + + + + +## GET ALL GOALS +@goals_bp.route("", methods=["GET"]) +def get_all_goals(): + goals = Goal.query.all() + response = [] + + for goal in goals: + response.append(goal.to_dict()) + return jsonify(response), 200 + +#GET ONE GOAL +@goals_bp.route("/", methods=["GET"]) +def get_one_goal(goal_id): + goal = validate_id(Goal, goal_id) #id instead of goal_id + response_body = { + "goal": goal.to_dict() + } + return response_body + +#UPDATE GOAL +@goals_bp.route("/", methods=["PUT"]) +def update_goal(goal_id): + goal = validate_id(Goal, goal_id) + request_body = request.get_json() + goal.title = request_body["title"] + + db.session.commit() + response_body = { + "goal": goal.to_dict() + } + return make_response(response_body, 200) + +#DELETE ONE GOAL +@goals_bp.route("/", methods=["DELETE"]) +def delete_goal(goal_id): + goal = validate_id(Goal, goal_id) + + goal_dict = goal.to_dict() + + db.session.delete(goal) + db.session.commit() + + return { + "details": f'Goal {goal_id} "{goal_dict["title"]}" successfully deleted'} + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/32258db1269b_.py b/migrations/versions/32258db1269b_.py new file mode 100644 index 000000000..201790361 --- /dev/null +++ b/migrations/versions/32258db1269b_.py @@ -0,0 +1,30 @@ +"""empty message + +Revision ID: 32258db1269b +Revises: e5eff1918c0a +Create Date: 2022-11-10 19:52:03.585756 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '32258db1269b' +down_revision = 'e5eff1918c0a' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/e5eff1918c0a_.py b/migrations/versions/e5eff1918c0a_.py new file mode 100644 index 000000000..6723dd0c6 --- /dev/null +++ b/migrations/versions/e5eff1918c0a_.py @@ -0,0 +1,40 @@ +"""empty message + +Revision ID: e5eff1918c0a +Revises: +Create Date: 2022-11-06 18:12:28.366487 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'e5eff1918c0a' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.Integer(), nullable=True), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index cacdbc36e..db54fe283 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==6.5.0 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -30,5 +31,6 @@ requests==2.25.1 six==1.15.0 SQLAlchemy==1.3.23 toml==0.10.2 +tomli==2.0.1 urllib3==1.26.5 Werkzeug==1.0.1 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..925a7bb1f 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,23 +51,21 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act - response = client.get("/tasks/1") + task_id = "1" + response = client.get(f"/tasks/{task_id}") response_body = response.get_json() # Assert assert response.status_code == 404 + assert response_body == {"message": f"{task_id} not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): + # TODO revert task id 3 to 1 + task_id = 1 # Act response = client.post("/tasks", json={ "title": "A Brand New Task", @@ -80,20 +78,20 @@ def test_create_task(client): assert "task" in response_body assert response_body == { "task": { - "id": 1, + "id": task_id, "title": "A Brand New Task", "description": "Test Description", "is_complete": False } } - new_task = Task.query.get(1) + new_task = Task.query.get(task_id) assert new_task assert new_task.title == "A Brand New Task" assert new_task.description == "Test Description" assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,8 +117,9 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_update_task_not_found(client): + task_id = 1 # Act response = client.put("/tasks/1", json={ "title": "Updated Task Title", @@ -130,14 +129,15 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "1 not found"} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") + def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +152,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,16 +160,18 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "1 not found"} + # in all the raise exceptions i asserted response body == [] empty list + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - assert Task.query.all() == [] + + # assert Task.query.all() == [] + -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +188,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") + def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..41f3eccde 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..d31e4d905 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -4,8 +4,7 @@ from app.models.task import Task import pytest - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +41,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +61,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +98,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +118,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +126,16 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {'message': '1 not found'} + - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +143,9 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {'message': '1 not found'} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..fa2ecf759 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ import pytest +from app.models.goal import Goal + -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -11,8 +12,6 @@ def test_get_goals_no_saved_goals(client): assert response.status_code == 200 assert response_body == [] - -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +28,6 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +44,19 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + assert response.status_code == 404 + assert response_body == {"message": "1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +75,42 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + # Assert + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" -@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + goal_id = 1 # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": "1 not found"} + + -@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -122,29 +125,24 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") + response_body = response.get_json() assert response.status_code == 404 + assert response_body == {"message": "1 not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - + # raise Exception("Complete test with assertion about response body") -@pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - + #raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + # Assert + assert response.status_code == 404 + assert response_body == {"message": "1 not found"} + -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..179514389 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") + def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,6 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +50,13 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +73,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +98,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()