From c12f26bdb9067c09d8eb7d83a5a39e79e284bc43 Mon Sep 17 00:00:00 2001 From: Fahad Farrukh Date: Fri, 25 Nov 2022 12:07:24 +0500 Subject: [PATCH] CUR-4454: H5P resource settings shared API will only be accessible if shared is true, removed access when indexing was approved. --- app/Http/Controllers/Api/V1/ActivityController.php | 3 +-- app/Http/Controllers/Api/V1/IndependentActivityController.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/Api/V1/ActivityController.php b/app/Http/Controllers/Api/V1/ActivityController.php index a58ba7a61..fc022fc28 100644 --- a/app/Http/Controllers/Api/V1/ActivityController.php +++ b/app/Http/Controllers/Api/V1/ActivityController.php @@ -729,8 +729,7 @@ public function getH5pResourceSettingsOpen(Activity $activity) */ public function getH5pResourceSettingsShared(Activity $activity) { - // 3 is for indexing approved - see Project Model @indexing property - if ($activity->shared || ($activity->playlist->project->indexing === (int)config('constants.indexing-approved'))) { + if ($activity->shared) { $h5p = App::make('LaravelH5p'); $core = $h5p::$core; $settings = $h5p::get_editor($content = null, 'preview'); diff --git a/app/Http/Controllers/Api/V1/IndependentActivityController.php b/app/Http/Controllers/Api/V1/IndependentActivityController.php index 2cbac2bca..e629bff92 100644 --- a/app/Http/Controllers/Api/V1/IndependentActivityController.php +++ b/app/Http/Controllers/Api/V1/IndependentActivityController.php @@ -792,8 +792,7 @@ public function getH5pResourceSettings(IndependentActivity $independent_activity */ public function getH5pResourceSettingsShared(IndependentActivity $independent_activity) { - // 3 is for indexing approved - see IndependentActivity Model @indexing property - if ($independent_activity->shared || ($independent_activity->indexing === (int)config('constants.indexing-approved'))) { + if ($independent_activity->shared) { $h5p = App::make('LaravelH5p'); $core = $h5p::$core; $settings = $h5p::get_editor();