[rqd] Fix file logging to handle non-ASCII characters without timestamp #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the logging logic to use the file name for appending logs. - Corrected file logging to ensure non-ASCII characters are properly handled when RQD_PREPEND_TIMESTAMP is False.
|
This change fixes the problem found by @lithorus and described in the PR: #1335 (comment) |
DiegoTavares
approved these changes
Jul 16, 2024
DiegoTavares
merged commit cddb6c9
into
AcademySoftwareFoundation:master
12 checks passed
n-jay
pushed a commit
to n-jay/OpenCue
that referenced
this pull request
Jul 26, 2024
…ademySoftwareFoundation#1417) - Updated the logging logic to use the file name for appending logs. - Corrected file logging to ensure non-ASCII characters are properly handled when RQD_PREPEND_TIMESTAMP is False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeErrorand fixes the broken file logging.self.rqlogis a file object and not a string.