Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Python AllocationTransform Example #473

Closed
sobotka opened this issue Oct 15, 2017 · 3 comments
Closed

Typo in Python AllocationTransform Example #473

sobotka opened this issue Oct 15, 2017 · 3 comments
Labels
Documentation Documentation related development and/or updates.

Comments

@sobotka
Copy link
Contributor

sobotka commented Oct 15, 2017

Line 20 of https://github.com/imageworks/OpenColorIO/blob/master/docs/developers/bindings/PythonTransforms.rst

The constant ALLOCATION isn't present, as defined by the constants.

Should probably be a viable constant?

   # Allocation
    self.assertEqual(OCIO.Constants.ALLOCATION_UNKNOWN, "unknown")
    self.assertEqual(OCIO.Constants.ALLOCATION_UNIFORM, "uniform")
    self.assertEqual(OCIO.Constants.ALLOCATION_LG2, "lg2")
@scoopxyz
Copy link
Contributor

Not sure I follow what you're saying? The constants listed above resolve to those strings.

@scoopxyz scoopxyz added the Documentation Documentation related development and/or updates. label Nov 13, 2017
@sobotka
Copy link
Contributor Author

sobotka commented Nov 13, 2017

As quoted from the page:

transform.setAllocation(OCIO.Constants.ALLOCATION)

Where "ALLOCATION" doesn't exist.

@dbr
Copy link
Contributor

dbr commented Nov 15, 2017

(made related ticket #481 - would be good to setup doctest type thing to catch errors like this in example code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related development and/or updates.
Projects
None yet
Development

No branches or pull requests

3 participants