Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS w/ MSYS2 MinGW #2100

Closed
kmilos opened this issue Nov 29, 2024 · 4 comments
Closed

FTBFS w/ MSYS2 MinGW #2100

kmilos opened this issue Nov 29, 2024 · 4 comments

Comments

@kmilos
Copy link

kmilos commented Nov 29, 2024

Both GCC and Clang fail w/ _mm_pow_ps error on Windows:

https://github.com/msys2/MINGW-packages/actions/runs/12086725004/job/33706625136?pr=22697#step:11:512
https://github.com/msys2/MINGW-packages/actions/runs/12086725004/job/33706625435?pr=22697#step:11:510

2.3.x was building just fine w/o patching.

Note that MSYS2 targets -march=nocona -msahf (so no SSSE3, SSE4.2, AVX...)

@kmilos kmilos changed the title FTBS w/ MSYS2 MinGW FTBFS w/ MSYS2 MinGW Dec 2, 2024
@lazka
Copy link

lazka commented Dec 8, 2024

Similar code is guarded differently, compare:

  • #if (_MSC_VER >= 1920) && (OCIO_USE_AVX)
    // MSVC 2019+ has built-in _mm_pow_ps() SVML intrinsic implementation
    // accessible through immintrin.h. Therefore precise SIMD version is available
    // only when compiled with MSVC and AVX support.
    template<>
    __m128 Renderer_PQ_TO_LIN_SSE<false>::myPower(__m128 x, __m128 exp)
    {
    return _mm_pow_ps(x, exp);
    }
    #endif
  • #ifdef _WIN32
    // Only Windows compilers have built-in _mm_pow_ps() SVML intrinsic
    // implementation, so non-fast SIMD version is available only on Windows for
    // now.
    template<>
    __m128 Renderer_LIN_TO_PQ_SSE<false>::myPower(__m128 x, __m128 exp)
    {
    return _mm_pow_ps(x, exp);
    }
    #endif // _WIN32

@lazka
Copy link

lazka commented Dec 8, 2024

I noticed that the guard is fixed as part of #2089

@lazka
Copy link

lazka commented Dec 19, 2024

@kmilos with #2089 merged this can be closed, right?

@kmilos
Copy link
Author

kmilos commented Dec 19, 2024

Indeed, thanks.

@kmilos kmilos closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants