Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ErrorMessage type from spark-commons #2170

Open
benedeki opened this issue Feb 1, 2023 · 0 comments · May be fixed by #2177
Open

Use ErrorMessage type from spark-commons #2170

benedeki opened this issue Feb 1, 2023 · 0 comments · May be fixed by #2177
Assignees
@TebaleloS
Labels
Conformance Conformance Job affected feature New feature good first issue Good for newcomers priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Standardization Standardization Job affected
Milestone
Release 3.1

Comments

@benedeki
Copy link
Collaborator

benedeki commented Feb 1, 2023

Background

Let's unify the ErrorMessage type across our products and repos.

Feature

After SparkCommons:#78 have been finished and released remove the ErrorMessage definition and all common things from Enceladus and use the spark-commons one.
@benedeki benedeki added refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code good first issue Good for newcomers feature New feature Conformance Conformance Job affected Standardization Standardization Job affected priority: medium Important but not urgent labels Feb 1, 2023
TebaleloS added a commit that referenced this issue Feb 24, 2023
@TebaleloS
Fixes #2170 - Replaced ErrorMessages and Mapping with spark-common Er…
eff8ef0 
…rorMessages and Mapping
TebaleloS added a commit that referenced this issue Feb 24, 2023
@TebaleloS
Fixes #2170 - Refactored some errorMessages imports
133bf0a
TebaleloS added a commit that referenced this issue Feb 24, 2023
@TebaleloS
Fixes #2170 - Removed irrelevant doc
8d4b3c6
@TebaleloS TebaleloS linked a pull request Feb 24, 2023 that will close this issue
Open
TebaleloS added a commit that referenced this issue Mar 2, 2023
@TebaleloS
Revert "Fixes #2170 - Removed irrelevant doc"
af390cb 
This reverts commit 8d4b3c6.
TebaleloS added a commit that referenced this issue Mar 2, 2023
@TebaleloS
Merge remote-tracking branch 'origin/develop' into feature/#2170-Use-…
dba19a7 
…ErrorMessage-type-from-spark-commons
TebaleloS added a commit that referenced this issue Mar 2, 2023
@TebaleloS
Fixes #2170 - Removed unused imports and refactored complex imports
f70cf45
@benedeki benedeki added this to the Release 3.1 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
Conformance Conformance Job affected feature New feature good first issue Good for newcomers priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Standardization Standardization Job affected
Projects
None yet
Milestone
Release 3.1
Development

Successfully merging a pull request may close this issue.

Use error message type from spark commons: 2170 AbsaOSS/enceladus
2 participants
@benedeki @TebaleloS