-
Notifications
You must be signed in to change notification settings - Fork 105
ml: evaluate insightface 1.0.1 against real antelopev2 weights #404
Copy link
Copy link
Open
Labels
backendFastAPI, database, storage, and API workFastAPI, database, storage, and API workmlModel inference, embeddings, OCR, captions, and search relevanceModel inference, embeddings, OCR, captions, and search relevanceneeds triageNeeds maintainer classificationNeeds maintainer classificationpriority: mediumUseful issue with moderate urgencyUseful issue with moderate urgencyresearchNeeds investigation, comparison, or design proposal before implementationNeeds investigation, comparison, or design proposal before implementation
Description
Metadata
Metadata
Assignees
Labels
backendFastAPI, database, storage, and API workFastAPI, database, storage, and API workmlModel inference, embeddings, OCR, captions, and search relevanceModel inference, embeddings, OCR, captions, and search relevanceneeds triageNeeds maintainer classificationNeeds maintainer classificationpriority: mediumUseful issue with moderate urgencyUseful issue with moderate urgencyresearchNeeds investigation, comparison, or design proposal before implementationNeeds investigation, comparison, or design proposal before implementation
Why this is manual
Dependabot proposed
insightface0.7.3 → 1.0.1 in #402. It passed CI, and that means almost nothing here:insightfaceis only installed by thecpuandnvidiaextras,backend-checkrunsuv sync --group dev, and no job imports it. The green checkmark covers zero lines of the package.It is now in the Dependabot
ignorelist alongsidetorch/torchvisionso it stops riding along in the majors group. Same tradeoff as those: security advisories will still raise alerts, but will not self-open a PR. Keep this issue open while that ignore exists.What makes a major here risky
backend/src/find_api/ml/face_detector.pyalready works around antelopev2's packaging:That retry exists because the release extracts ONNX files under a nested directory. Model packaging and download paths are exactly the sort of thing a 1.0 release cleans up — so the most likely breakage is the thing nothing in CI can observe.
Acceptance
cpuextra withinsightface==1.0.1and let it download antelopev2 from scratch (delete the cached weights first — a warm cache hides path changes).FaceAnalysis(name="antelopev2", ...)resolves without falling into theAssertionErrorbranch, and note whether the nested-layout retry is still needed or can be deleted.face.bbox,face.det_score, andface.embeddingstill have the shapesdetect_faces()expects.resolve_execution/ctx_id), on CPU at minimum.The embedding-dimension check is the one that matters most. If it changed, this stops being a dependency bump.
Related: #382 (torch, same ignore rationale), #397 (OCR tests skip in CI for the same install-extras reason).