Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester C] Edit Command Allows Creation of Duplicate Organizations with Same Name #118

Open
soc-pe-bot opened this issue Nov 3, 2023 · 1 comment
Labels
severity.Medium A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label) type.DocumentationBug Something's incorrect, specifically w.r.t. documentation (CS2103T label)

Comments

@soc-pe-bot
Copy link

Title: Edit Command Allows Creation of Duplicate Organizations with the Same Name

Description:
While using the application, I encountered an issue with the edit command, which allows the creation of two organizations with the same name. This behavior is unexpected and not documented in the User Guide.

Details:

Steps to Reproduce:

  1. Open the application with default jar values.
  2. Enter the command: edit 2 --name Alex Yeoh Inc. followed by pressing Enter.

Expected Behavior:
The application should not allow the creation of a new organization with the same name as an existing one, and it should provide an error message or prevent the creation of a duplicate organization.

Actual Behavior:
The edit command successfully creates a new organization with the name "Alex Yeoh Inc." even if an organization with the same name already exists.

Severity/Type Label:
This issue can be categorized as a high severity bug, as it allows for the creation of duplicate organizations with the same name, which can lead to confusion and data integrity problems.

I would like to emphasize that this issue might lead to unexpected results for users who assume that organization names are unique by default. It's possible that this behavior is unintentional, and the User Guide does not provide clarification on the role of the ID as a unique identifier.

Suggestion for Improvement:
To resolve this issue, it would be helpful to ensure that the edit command enforces the uniqueness of organization names and provides clear documentation in the User Guide regarding the uniqueness criteria, possibly by mentioning the role of the ID as a unique identifier. This will prevent the unintended creation of duplicate organizations and enhance the user experience.

image.png


Labels: severity.High type.FunctionalityBug
original: eyelessrhyme7/ped#2

@wxwern wxwern added other.NA This issue is not applicable severity.Medium A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label) type.DocumentationBug Something's incorrect, specifically w.r.t. documentation (CS2103T label) other.OutOfScope This issue is out of scope type.FeatureFlaw A flaw with functionality (CS2103T label) and removed other.NA This issue is not applicable other.OutOfScope This issue is out of scope labels Nov 4, 2023
@wxwern
Copy link

wxwern commented Nov 4, 2023

Out of scope - we allow duplicate names and only enforce unique IDs. A system to ensure this is not a user error would be a warning as per #140. For now, documentation should be updated to reflect this.

@wxwern wxwern removed the type.FeatureFlaw A flaw with functionality (CS2103T label) label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A flaw that may hamper app usage or documentation understanding, but is still usable (CS2103T label) type.DocumentationBug Something's incorrect, specifically w.r.t. documentation (CS2103T label)
Projects
None yet
Development

No branches or pull requests

2 participants