Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of logging #3

Open
LukeCarrier opened this issue Jan 6, 2020 · 0 comments
Open

Use of logging #3

LukeCarrier opened this issue Jan 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@LukeCarrier
Copy link
Contributor

At the moment we make use of the logger as an access log, refraining from logging errors outside of those that trigger HTTP 500s. This isn't particularly useful as a debugging aid as it prevents us from logging the context that'd be useful to help diagnose issues.

Should we consider making the existing log messages part of our interface and testing against them, or should we refocus logging around diagnostics and error conditions?
@LukeCarrier LukeCarrier added the enhancement New feature or request label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukeCarrier