Support dynamic simd framework and using term expr as example (milvus-io#25260)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>

Author: zhagnlu

Makefile

@@ -24,7 +24,10 @@ useasan = false
 ifeq (${USE_ASAN}, true)
 useasan = true
 endif
-opensimd = OFF
+use_dynamic_simd = OFF
+ifdef USE_DYNAMIC_SIMD
+	use_dynamic_simd = ${USE_DYNAMIC_SIMD}
+endif
 
 export GIT_BRANCH=master
 
@@ -149,19 +152,19 @@ generated-proto: download-milvus-proto build-3rdparty
 
 build-cpp: generated-proto
 	@echo "Building Milvus cpp library ..."
-	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -i ${opensimd})
+	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -y ${use_dynamic_simd})
 
 build-cpp-gpu: generated-proto
 	@echo "Building Milvus cpp gpu library ..."
-	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -g -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -i ${opensimd})
+	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -g -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -y ${use_dynamic_simd})
 
 build-cpp-with-unittest: generated-proto
 	@echo "Building Milvus cpp library with unittest ..."
-	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -u -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -i ${opensimd})
+	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -u -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -y ${use_dynamic_simd})
 
 build-cpp-with-coverage: generated-proto
 	@echo "Building Milvus cpp library with coverage and unittest ..."
-	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -u -a ${useasan} -c -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -i ${opensimd})
+	@(env bash $(PWD)/scripts/core_build.sh -t ${mode} -u -a ${useasan} -c -f "$(CUSTOM_THIRDPARTY_PATH)" -n ${disk_index} -y ${use_dynamic_simd})
 
 check-proto-product: generated-proto
 	 @(env bash $(PWD)/scripts/check_proto_product.sh)

internal/core/CMakeLists.txt

@@ -29,6 +29,10 @@ if ( MILVUS_GPU_VERSION )
     add_definitions(-DMILVUS_GPU_VERSION)
 endif ()
 
+if ( USE_DYNAMIC_SIMD ) 
+    add_definitions(-DUSE_DYNAMIC_SIMD)
+endif()
+
 project(core)
 include(CheckCXXCompilerFlag)
 if ( APPLE )

internal/core/src/CMakeLists.txt

@@ -35,3 +35,6 @@ add_subdirectory( index )
 add_subdirectory( query )
 add_subdirectory( segcore )
 add_subdirectory( indexbuilder )
+if(USE_DYNAMIC_SIMD)
+    add_subdirectory( simd )
+endif()

internal/core/src/common/Types.h

@@ -140,7 +140,7 @@ using IndexType = knowhere::IndexType;
 // Plus 1 because we can't use greater(>) symbol
 constexpr size_t REF_SIZE_THRESHOLD = 16 + 1;
 
-using BitSetBlockType = BitsetType::block_type;
+using BitsetBlockType = BitsetType::block_type;
 constexpr size_t BITSET_BLOCK_SIZE = sizeof(BitsetType::block_type);
 constexpr size_t BITSET_BLOCK_BIT_SIZE = sizeof(BitsetType::block_type) * 8;
 template <typename T>

internal/core/src/query/CMakeLists.txt

@@ -30,4 +30,8 @@ set(MILVUS_QUERY_SRCS
         PlanProto.cpp
         )
 add_library(milvus_query ${MILVUS_QUERY_SRCS})
-target_link_libraries(milvus_query milvus_index)
+if(USE_DYNAMIC_SIMD)
+        target_link_libraries(milvus_query milvus_index milvus_simd)
+else() 
+        target_link_libraries(milvus_query milvus_index)
+endif()

internal/core/src/query/visitors/ExecExprVisitor.cpp

@@ -35,6 +35,8 @@
 #include "segcore/SegmentGrowingImpl.h"
 #include "simdjson/error.h"
 #include "query/PlanProto.h"
+#include "simd/hook.h"
+
 namespace milvus::query {
 // THIS CONTAINS EXTRA BODY FOR VISITOR
 // WILL BE USED BY GENERATOR
@@ -186,7 +188,10 @@ AppendOneChunk(BitsetType& result, const FixedVector<bool>& chunk_res) {
     // Append a value once instead of BITSET_BLOCK_BIT_SIZE times.
     auto AppendBlock = [&result](const bool* ptr, int n) {
         for (int i = 0; i < n; ++i) {
-            BitSetBlockType val = 0;
+#if defined(USE_DYNAMIC_SIMD)
+            auto val = milvus::simd::get_bitset_block(ptr);
+#else
+            BitsetBlockType val = 0;
             // This can use CPU SIMD optimzation
             uint8_t vals[BITSET_BLOCK_SIZE] = {0};
             for (size_t j = 0; j < 8; ++j) {
@@ -195,8 +200,9 @@ AppendOneChunk(BitsetType& result, const FixedVector<bool>& chunk_res) {
                 }
             }
             for (size_t j = 0; j < BITSET_BLOCK_SIZE; ++j) {
-                val |= BitSetBlockType(vals[j]) << (8 * j);
+                val |= BitsetBlockType(vals[j]) << (8 * j);
             }
+#endif
             result.append(val);
             ptr += BITSET_BLOCK_SIZE * 8;
         }
@@ -1782,11 +1788,31 @@ ExecExprVisitor::ExecTermVisitorImplTemplate(TermExpr& expr_raw) -> BitsetType {
     auto index_func = [&terms, n](Index* index) {
         return index->In(n, terms.data());
     };
-    auto elem_func = [&terms, &term_set](MayConstRef<T> x) {
-        //// terms has already been sorted.
-        // return std::binary_search(terms.begin(), terms.end(), x);
+
+#if defined(USE_DYNAMIC_SIMD)
+    std::function<bool(MayConstRef<T> x)> elem_func;
+    if (n <= milvus::simd::TERM_EXPR_IN_SIZE_THREAD) {
+        elem_func = [&terms, &term_set, n](MayConstRef<T> x) {
+            if constexpr (std::is_integral<T>::value ||
+                          std::is_floating_point<T>::value) {
+                return milvus::simd::find_term_func<T>(terms.data(), n, x);
+            } else {
+                // For string type, simd performance not better than set mode
+                static_assert(std::is_same<T, std::string>::value ||
+                              std::is_same<T, std::string_view>::value);
+                return term_set.find(x) != term_set.end();
+            }
+        };
+    } else {
+        elem_func = [&term_set, n](MayConstRef<T> x) {
+            return term_set.find(x) != term_set.end();
+        };
+    }
+#else
+    auto elem_func = [&term_set](MayConstRef<T> x) {
         return term_set.find(x) != term_set.end();
     };
+#endif
 
     return ExecRangeVisitorImpl<T>(
         expr.column_.field_id, index_func, elem_func);

internal/core/src/simd/CMakeLists.txt

@@ -0,0 +1,36 @@
+# Copyright (C) 2019-2020 Zilliz. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed under the License
+# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+# or implied. See the License for the specific language governing permissions and limitations under the License
+
+set(MILVUS_SIMD_SRCS
+    ref.cpp
+    hook.cpp
+)
+
+if (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "x86_64")
+    # x86 cpu simd
+    message ("simd using x86_64 mode")
+    list(APPEND MILVUS_SIMD_SRCS
+                sse2.cpp
+                sse4.cpp
+                avx2.cpp
+                avx512.cpp
+    )
+    set_source_files_properties(sse4.cpp PROPERTIES COMPILE_FLAGS "-msse4.2")
+    set_source_files_properties(avx2.cpp PROPERTIES COMPILE_FLAGS "-mavx2")
+    set_source_files_properties(avx512.cpp PROPERTIES COMPILE_FLAGS "-mavx512f  -mavx512dq -mavx512bw")
+elseif (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm*")
+    # TODO: add arm cpu simd
+endif()
+
+add_library(milvus_simd ${MILVUS_SIMD_SRCS})
+
+# Link the milvus_simd library with other libraries as needed
+target_link_libraries(milvus_simd milvus_log)