From 055434822c099db8337f73a069fc09141cd640b4 Mon Sep 17 00:00:00 2001 From: Peter Brightwell Date: Wed, 11 Sep 2024 09:24:19 +0100 Subject: [PATCH 1/4] Fix copy/paste typo as per #169 --- examples/sender-stage-absolute-success.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/sender-stage-absolute-success.json b/examples/sender-stage-absolute-success.json index 4baf436d..47939c0f 100644 --- a/examples/sender-stage-absolute-success.json +++ b/examples/sender-stage-absolute-success.json @@ -2,7 +2,7 @@ "master_enable": true, "receiver_id": null, "activation": { - "mode": "activate_scheduled_relative", + "mode": "activate_scheduled_absolute", "requested_time": "1496759200:0", "activation_time": "1496759200:5000" }, From 5387c5ea2308394b9e7ac350fffe0af6b4bc9455 Mon Sep 17 00:00:00 2001 From: Jonas Reucher Date: Wed, 26 Mar 2025 11:36:24 +0100 Subject: [PATCH 2/4] Remove duplicate keys from schema defintions (#176) --- APIs/schemas/activation-schema.json | 1 - APIs/schemas/receiver_transport_params_mqtt.json | 1 - APIs/schemas/receiver_transport_params_rtp.json | 1 - APIs/schemas/receiver_transport_params_websocket.json | 1 - APIs/schemas/sender_transport_params_mqtt.json | 1 - APIs/schemas/sender_transport_params_rtp.json | 1 - APIs/schemas/sender_transport_params_websocket.json | 1 - 7 files changed, 7 deletions(-) diff --git a/APIs/schemas/activation-schema.json b/APIs/schemas/activation-schema.json index 27cefb79..676a998f 100644 --- a/APIs/schemas/activation-schema.json +++ b/APIs/schemas/activation-schema.json @@ -1,6 +1,5 @@ { "$schema": "http://json-schema.org/draft-04/schema#", - "type": "object", "title": "Activation resource", "description": "Parameters concerned with activation of the transport parameters", "type": "object", diff --git a/APIs/schemas/receiver_transport_params_mqtt.json b/APIs/schemas/receiver_transport_params_mqtt.json index 84f6548b..a9cf65da 100644 --- a/APIs/schemas/receiver_transport_params_mqtt.json +++ b/APIs/schemas/receiver_transport_params_mqtt.json @@ -3,7 +3,6 @@ "description": "Describes MQTT Receiver transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. MQTT Receivers must support all parameters in this schema.", "title": "MQTT Receiver Transport Parameters", "type": "object", - "title": "Receiver Input", "properties": { "source_host": { "type": [ diff --git a/APIs/schemas/receiver_transport_params_rtp.json b/APIs/schemas/receiver_transport_params_rtp.json index ee119205..bc51d26d 100644 --- a/APIs/schemas/receiver_transport_params_rtp.json +++ b/APIs/schemas/receiver_transport_params_rtp.json @@ -3,7 +3,6 @@ "description": "Describes RTP Receiver transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. Receivers must support at least the `source_ip`, `interface_ip`, `rtp_enabled` and `destination_port` parameters, and must support the `multicast_ip` parameter if they are capable of multicast operation. Receivers supporting FEC and/or RTCP must support parameters prefixed with `fec` and `rtcp` respectively.", "title": "RTP Receiver Transport Parameters", "type": "object", - "title": "Receiver Input", "properties": { "source_ip": { "type": [ diff --git a/APIs/schemas/receiver_transport_params_websocket.json b/APIs/schemas/receiver_transport_params_websocket.json index 38f16814..d631297b 100644 --- a/APIs/schemas/receiver_transport_params_websocket.json +++ b/APIs/schemas/receiver_transport_params_websocket.json @@ -3,7 +3,6 @@ "description": "Describes WebSocket Receiver transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. WebSocket Receivers must support all parameters in this schema.", "title": "WebSocket Receiver Transport Parameters", "type": "object", - "title": "Receiver Input", "properties": { "connection_uri": { "type": [ diff --git a/APIs/schemas/sender_transport_params_mqtt.json b/APIs/schemas/sender_transport_params_mqtt.json index a7e98074..e61fc0cc 100644 --- a/APIs/schemas/sender_transport_params_mqtt.json +++ b/APIs/schemas/sender_transport_params_mqtt.json @@ -3,7 +3,6 @@ "description": "Describes MQTT Sender transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. MQTT Senders must support all properties in this schema.", "title": "MQTT Sender Transport Parameters", "type": "object", - "title": "Sender Output", "properties": { "destination_host": { "type": [ diff --git a/APIs/schemas/sender_transport_params_rtp.json b/APIs/schemas/sender_transport_params_rtp.json index b849b9b7..9f3e27e5 100644 --- a/APIs/schemas/sender_transport_params_rtp.json +++ b/APIs/schemas/sender_transport_params_rtp.json @@ -3,7 +3,6 @@ "description": "Describes RTP Sender transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. As a minimum all senders must support `source_ip`, `destination_ip`, `source_port`, `rtp_enabled` and `destination_port`. Senders supporting FEC and/or RTCP must support parameters prefixed with `fec` and `rtcp` respectively.", "title": "RTP Sender Transport Parameters", "type": "object", - "title": "Sender Output", "properties": { "source_ip": { "type": "string", diff --git a/APIs/schemas/sender_transport_params_websocket.json b/APIs/schemas/sender_transport_params_websocket.json index 65c187f2..e7c50ca2 100644 --- a/APIs/schemas/sender_transport_params_websocket.json +++ b/APIs/schemas/sender_transport_params_websocket.json @@ -3,7 +3,6 @@ "description": "Describes WebSocket Sender transport parameters. The constraints in this schema are minimum constraints, but may be further constrained at the constraints endpoint. WebSocket Senders must support all parameters in this schema.", "title": "WebSocket Sender Transport Parameters", "type": "object", - "title": "Sender Output", "properties": { "connection_uri": { "type": [ From cbd9ccc14b26dad6bf6beb5f99ad40495e70ae3a Mon Sep 17 00:00:00 2001 From: Pete-Cordell Date: Wed, 26 Mar 2025 10:55:28 +0000 Subject: [PATCH 3/4] Clarify what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate" (#175) It's unclear what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate". Should it be null or absent or either. The examples show it set to null but absent doesn't seem unreasonable so I've gone with that option. Please amend as required. --- APIs/schemas/activation-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/APIs/schemas/activation-schema.json b/APIs/schemas/activation-schema.json index 676a998f..3195fbf6 100644 --- a/APIs/schemas/activation-schema.json +++ b/APIs/schemas/activation-schema.json @@ -22,7 +22,7 @@ }] }, "requested_time": { - "description": "String formatted TAI timestamp (:) indicating time (absolute or relative) for activation. Should be null or not present if 'mode' is null.", + "description": "String formatted TAI timestamp (:) indicating time (absolute or relative) for activation. Should be null or not present if 'mode' is null or activate_immediate.", "anyOf": [{ "type": "string", "pattern": "^[0-9]+:[0-9]+$" From 78f74c539d5ef19ee6c1c2593bf21784940c0588 Mon Sep 17 00:00:00 2001 From: N-Nagorny <15526762+N-Nagorny@users.noreply.github.com> Date: Wed, 26 Mar 2025 15:20:49 +0400 Subject: [PATCH 4/4] Behaviour: RTCP (#168) * Update Behaviour - RTP Transport Type.md Revised language in ARG call 2025-03-26 --------- Co-authored-by: Peter Brightwell --- docs/Behaviour - RTP Transport Type.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Behaviour - RTP Transport Type.md b/docs/Behaviour - RTP Transport Type.md index dd19582e..b83872c3 100644 --- a/docs/Behaviour - RTP Transport Type.md +++ b/docs/Behaviour - RTP Transport Type.md @@ -338,7 +338,7 @@ a=mid:Ch1 ## Operation with RTCP -RTCP provides various functions to support the operation of RTP, principally QoS reporting. RTCP is defined in Section 6 of RFC 3550, which suggests that the next highest odd port after the RTP port is used for its transmission. Where RTCP and forward error correction are both in use the RTP port SHOULD be chosen to be even, to satisfy the recommendations of both RFC 3550 and SMPTE 2022-5 without resulting in port collisions. +RTCP provides various functions to support the operation of RTP, principally QoS reporting. RTCP is defined in Section 6 of RFC 3550, and Section 11 of RFC 3550 suggests that RTP use an even destination port number and the corresponding RTCP stream use the next higher (odd) destination port number. (Note: this convention will also satisfy the recommendations of ST 2022-5 for cases where forward error correction is used.) Senders and Receivers supporting RTCP SHOULD comply with RFC 3605 when creating and receiving SDP files. An RFC 3605 compliant SDP file is shown below, along with the transport parameters that would be presented on the `/staged` endpoint by a Receiver that has parsed the file.