Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wdconvect CI #462

Merged
merged 2 commits into from
May 16, 2024
Merged

add wdconvect CI #462

merged 2 commits into from
May 16, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 16, 2024

No description provided.

@zingale
Copy link
Member Author

zingale commented May 16, 2024

closes #449

@zingale
Copy link
Member Author

zingale commented May 16, 2024

this gives diffs in the last digit. Not sure why...

@biboyd
Copy link
Collaborator

biboyd commented May 16, 2024

When I run on my machine I get

 vort                         3.7905619114e-13         0.089547619929
 pioverp0                    -1.3133053276e-05       1.3515909745e-05
 circ_velocity                2.4305549801e-15           273571.94181

which agrees with the CI calculation. Seems the benchmark is just off by a bit

@zingale
Copy link
Member Author

zingale commented May 16, 2024

probably the compiler version -- I'm using GCC 14.1. I think the CI is using 11.4.

Let me try bumping up the Ubuntu here

@zingale
Copy link
Member Author

zingale commented May 16, 2024

okay it passes if we run with Ubuntu 24.04 which uses GCC 13.2.

@zingale zingale merged commit 90d0160 into AMReX-Astro:development May 16, 2024
10 checks passed
@zingale zingale deleted the wdconvect_CI branch May 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @biboyd