-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert hbflx3 to C++ #2590
Convert hbflx3 to C++ #2590
Conversation
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-01/index.html |
I had an indexing error which is now fixed, can you try again? |
I've synchronized 3D with 1D and 2D. The 3D case was making some simplifying assumptions; the more general expression in 1D and 2D are now what we use, and they result in the 3D expression because r0 = 1 for 3D Cartesian. |
Source/radiation/HABEC.H
Outdated
bfm2 = 0.e0_rt; | ||
} | ||
else if (bct == LO_MARSHAK) { | ||
bfv = 2.e0_rt * beta * r[i - reg_ilo]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works as expected in 3D?
This PR now condenses all six faces of the grid into a single code block, and instead of using the vector of metric terms computed in a separate step, it now evaluates those metric terms inline. |
all radiation tests pass: |
PR summary
PR checklist
CHANGES
file has been updated, if appropriate