Skip to content

Commit

Permalink
remove sdc_solve_for_rhoe (#2572)
Browse files Browse the repository at this point in the history
This is no longer used since we are leveraging the same code paths as
simplified-SDC
  • Loading branch information
zingale authored Sep 23, 2023
1 parent c08dc99 commit 9d00bf8
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion Docs/source/sdc.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The options that affect the nonlinear solve are:
``integrator.atol_spec``, ``integrator.rtol_enuc``,
``integrator.atol_enuc``.

In all cases, the type of Jacobian (analytic or numerical) is determined by
In all cases, the type of Jacobian (analytic or numerical) is determined by
``integrator.jacobian``.


Expand Down
1 change: 0 additions & 1 deletion Exec/reacting_tests/bubble_convergence/inputs_2d.128
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1

castro.grav_source_type = 2
Expand Down
1 change: 0 additions & 1 deletion Exec/reacting_tests/bubble_convergence/inputs_2d.256
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1

castro.grav_source_type = 2
Expand Down
1 change: 0 additions & 1 deletion Exec/reacting_tests/bubble_convergence/inputs_2d.32
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1

castro.grav_source_type = 2
Expand Down
1 change: 0 additions & 1 deletion Exec/reacting_tests/bubble_convergence/inputs_2d.512
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1

castro.grav_source_type = 2
Expand Down
1 change: 0 additions & 1 deletion Exec/reacting_tests/bubble_convergence/inputs_2d.64
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1

castro.grav_source_type = 2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1"

srun ${CASTRO_EXEC} inputs_2d.64 ${RUNPARAMS} amr.plot_file=bubble_64_sdc4_plt &> 64.out
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ RUNPARAMS="
castro.sdc_order=2
castro.time_integration_method=2
castro.ppm_type=0
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1
castro.use_retry=0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1
castro.use_retry=0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ castro.sdc_order=4
castro.time_integration_method=2
castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=1"

srun ${CASTRO_EXEC} inputs.64 amr.plot_file=react_converge_64_sdc4_plt ${RUNPARAMS}
Expand Down
1 change: 0 additions & 1 deletion Exec/science/Detonation/nse_runs/inputs.template.true_sdc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ castro.sdc_quadrature = @@SDC_QUADRATURE@@

castro.limit_fourth_order=1
castro.use_reconstructed_gamma1=1
castro.sdc_solve_for_rhoe=1
castro.sdc_solver=2


Expand Down
1 change: 0 additions & 1 deletion Exec/science/flame/inputs.1d.sdc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ castro.do_react = 1
castro.time_integration_method = 2
castro.sdc_order = 4

castro.sdc_solve_for_rhoe = 1
castro.sdc_solver = 1
castro.sdc_solver_relax_factor = 1

Expand Down
3 changes: 0 additions & 3 deletions Source/driver/_cpp_parameters
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,6 @@ sdc_extra int 0
# which SDC nonlinear solver to use? 1 = Newton, 2 = VODE, 3 = VODE for first iter
sdc_solver int 1

# do we solve for (rho e) or (rho E) in the SDC nonlinear solve?
sdc_solve_for_rhoe int 1

# for 2-d axisymmetry, do we include the geometry source terms from Bernand-Champmartin?
use_axisymmetric_geom_source int 1

Expand Down

0 comments on commit 9d00bf8

Please sign in to comment.