diff --git a/Magpie/modes/benchmark/tracelens_inference.py b/Magpie/modes/benchmark/tracelens_inference.py index 80ae0fa..867ea83 100644 --- a/Magpie/modes/benchmark/tracelens_inference.py +++ b/Magpie/modes/benchmark/tracelens_inference.py @@ -38,7 +38,7 @@ logger = logging.getLogger(__name__) BACKUP_SUFFIX = ".tracelens.bak" -CLI_SPLIT_INFERENCE_TRACE = "TraceLens_split_inference_trace" +CLI_SPLIT_TRACE = "TraceLens_split_trace" CLI_INFERENCE_REPORT = "TraceLens_generate_perf_report_pytorch_inference" ATOM_MARK_TRACE_FLAG = "--mark-trace" SGLANG_PROFILE_CUDA_GRAPH_FLAG = "--enable-profile-cuda-graph" @@ -448,7 +448,7 @@ def analyze( missing_cli = [ name - for name in (CLI_SPLIT_INFERENCE_TRACE, CLI_INFERENCE_REPORT) + for name in (CLI_SPLIT_TRACE, CLI_INFERENCE_REPORT) if shutil.which(name) is None ] if missing_cli: @@ -882,7 +882,7 @@ def _run_splitter(self, rank0_trace: Path, split_dir: Path) -> Optional[str]: envs = self.config.envs split_dir.mkdir(parents=True, exist_ok=True) cmd = [ - CLI_SPLIT_INFERENCE_TRACE, + CLI_SPLIT_TRACE, str(rank0_trace), "-o", str(split_dir), @@ -919,7 +919,7 @@ def _run_splitter_in_container( envs = self.config.envs split_dir.mkdir(parents=True, exist_ok=True) cmd = [ - CLI_SPLIT_INFERENCE_TRACE, + CLI_SPLIT_TRACE, self._container_path(rank0_trace, workspace), "-o", self._container_path(split_dir, workspace), @@ -1809,7 +1809,7 @@ def is_tracelens_inference_enabled(config: BenchmarkConfig) -> bool: __all__ = [ "ATOM_MARK_TRACE_FLAG", "CLI_INFERENCE_REPORT", - "CLI_SPLIT_INFERENCE_TRACE", + "CLI_SPLIT_TRACE", "InferencePhasePick", "SGLANG_PROFILE_CUDA_GRAPH_FLAG", "SGLANG_SHAPE_DISCOVERY_FLAG", diff --git a/docs/how-to/benchmarking/profiling-options.md b/docs/how-to/benchmarking/profiling-options.md index 19719d6..97ab659 100644 --- a/docs/how-to/benchmarking/profiling-options.md +++ b/docs/how-to/benchmarking/profiling-options.md @@ -179,7 +179,7 @@ TraceLens provides automated analysis of torch profiler traces: | Command | Description | Output | |---------|-------------|--------| -| `TraceLens_`
`split_`
`inference`
`_trace` | Split vLLM/SGLang inference traces into phase windows | `torch_trace/trace_split/` | +| `TraceLens_`
`split_trace` | Split vLLM/SGLang inference traces into phase windows | `torch_trace/trace_split/` | | `TraceLens_`
`generate_perf`
`_report_pytorch`
`_inference` | Inference-aware prefill/decode reports and compact roofline summaries | `tracelens/` | | `TraceLens_`
`generate_perf`
`_report_pytorch` | Single-rank performance report | `tracelens_rank0_csvs/` | | `TraceLens_`
`generate_multi`
`_rank_collective`
`_report_pytorch` | Multi-rank collective analysis | `tracelens_collective_csvs/` | diff --git a/examples/benchmarks/benchmark_vllm_tracelens.yaml b/examples/benchmarks/benchmark_vllm_tracelens.yaml index 19816eb..d7a7e9d 100644 --- a/examples/benchmarks/benchmark_vllm_tracelens.yaml +++ b/examples/benchmarks/benchmark_vllm_tracelens.yaml @@ -44,7 +44,7 @@ benchmark: # TraceLens trace analysis - generates reports from torch traces # Commands: - # - TraceLens_split_inference_trace + # - TraceLens_split_trace # - TraceLens_generate_perf_report_pytorch_inference # Set analysis_mode: pytorch for the legacy direct PyTorch report flow. tracelens: diff --git a/tests/test_benchmark_support.py b/tests/test_benchmark_support.py index 78d58b0..16b7503 100644 --- a/tests/test_benchmark_support.py +++ b/tests/test_benchmark_support.py @@ -1695,7 +1695,7 @@ def test_tracelens_inference_analysis_runs_in_cpu_only_container( def fake_run(cmd, **_kwargs): docker_cmds.append(cmd) bash_cmd = cmd[-1] - if "TraceLens_split_inference_trace" in bash_cmd: + if "TraceLens_split_trace" in bash_cmd: split_dir = torch_trace_dir / "trace_split" split_dir.mkdir(parents=True, exist_ok=True) decode_trace = split_dir / "decode.trace.json.gz"