-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for encryption #120
Comments
I'm also interested in this feature. BLU motion or BLU window should always use encrypted communication, so the Shelly scripting should support encryption. |
Have you checked here? |
Hi |
Hello. I was just trying to implement encryption for a project and could not get that to work, so +1 for this. |
Offering only unsecure communication is a major omission for the BTHome BLE products and needs to be fixed. It is relatively easy to clone an BTHome BLE button's messages and by doing that potentially opening garage doors or bypass home security. Until encryption is supported BTHome BLE product's use cases are limited and weaken the security of Shelly's ecosystem. Shelly products should offer and encourage the use of secure communication. |
Hi, Gen2 (Plus) devices lack of free space, we can not add such a feature easily. Anyway Gen3 and Pro devices supports encrypted bthome/ble devices via feature called BTHome components. And we will add aes apis in the scripts soon. Have a nice day. |
that's good news !!! |
I wish I would have known before I bought a hole bunch of gen 2 devices that BLE encryption is only available for gen 3 devcies. |
Would it not be possible to do the encrypt / decrypt on a (1) Gen 3 device and run the script / functions from that device? |
@NoUsername10 Even for non-security stuff, I don't like when any kid can turn on and off my lights with a simple BT cloning device. I still think the proper solution is to have the decryption feature added to Gen2. The AES code is already in the flash as it used for Wifi, so I can't see that this would add a lot of additional memory. |
@hwmaier Then send actions through wifi, not direct connections to devices from BLE devices though, but no need to change devices. |
@NoUsername10 This is possible in some configurations if you have a Gen 3 within the same BT range of the BT sensor and then also within Wifi range of the Gen 2 device. Unfortunately this is not always the case. For example a driveway entry gate or a garage door where you would want to use encrypted BT from a BT button to prevent unauthorised access to the house. |
@hwmaier Yes, there are some use cases that are not optimal, that was only as a workaround for your situation. If the bluetooth signal is received in a gen 2 device, the payload goes to all listeners if I'm not mistaken? |
If I am not mistaken, encrypted communication is not supported by these scripts, because it says in the code:
So security relies entirely on the MAC address comparison, right? That is pretty weak. Could you please add support for encrypted payloads to the scripts collection?
The text was updated successfully, but these errors were encountered: