Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize test/sampler.jl #98

Open
mtanneau opened this issue Jun 20, 2024 · 2 comments
Open

Re-organize test/sampler.jl #98

mtanneau opened this issue Jun 20, 2024 · 2 comments

Comments

@mtanneau
Copy link
Contributor

We are starting to saturate test/sampler.jl, which currently includes unit tests for the data sampling code, and functional tests for the data-generation (OPF sampling and solving).

It would be good to separate those.
On top of my head:

  • tests for update! of OPF models should go with their respective formulations
  • tests for data distributions and sampling should be isolated, and preferably moved to a test/sampler folder (mimicking the structure of the source code)
  • tests for data generation (sampling and solving OPF instances) should be isolated too. It's less clear to me what this should look like.
    I'm thinking we might want to move code currently in exp/sampler.jl to source code.
@klamike
Copy link
Collaborator

klamike commented Jun 21, 2024

Ideally we can address #99 together with this (when moving exp/sampler.jl to source)

@mtanneau
Copy link
Contributor Author

I'll get started on moving exp/sampler.jl to source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants