Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rest of sumit code into here with a single common makefile #1

Open
jim-smith opened this issue Oct 21, 2022 · 2 comments
Open
Assignees

Comments

@jim-smith
Copy link
Contributor

jim-smith commented Oct 21, 2022

Hi @rpreen , would welcome your thoughts on this as a simplifying plan for distributing the code without all the netbeans-generated crap and without the need for separate repositories


Having edited the various makefiles, they are far more complex that they need be, and in particular by using different named sub-directories for different architectures within the dist directory they introduce a level of complexity that I don't think is justified.

I'm also not particularly convinced. about the desirability of requiring users to install cmake for creating the executables for the cpp files.

I suggest a structure something like:

src:
-- libfiles/
-- cell_suppression/
-- solver/
-- server/
-- thirdparty/ (the coin-or files with their licence)

dist/
holds the sumitlib.o, uweserver.jar, uwecellsuppresssion(.exe) and uwesolver(.exe) files

Makefile (single file at top level within src, no messing around with lower level ones with sub-directories)
all: uweserver, cellsuppression and solver as targets

Then if someone wants to add code that does something other than cell suppression, they can add new directories, pull from the lib if they want to etc.

@rpreen
Copy link
Contributor

rpreen commented Oct 21, 2022

Sounds reasonable to me.

@jim-smith
Copy link
Contributor Author

I've forked a branch and started work on it.
pushed to avoid losing work in extremis but needs makefile completing and cpp adding from coin-or

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants