Skip to content

Commit c357b11

Browse files
authored
fix: restore the old rank assign scheme (kleveross#70)
1 parent 09d6aaa commit c357b11

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

ftlib/impl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def __init__(
4646

4747
self.rank = None
4848
self.size = None
49-
self.member_list = None
49+
self.member_list = []
5050

5151
self.consensus = None
5252
self.commlib = None

ftlib/rank_assign_scheme.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ def get_rank_size(member_list, self_identity, old_member_list=[]):
1414
# str, ip (identity) of the 0-rank worker
1515
logging.debug("start to assigning rank")
1616
logging.debug("member_list: {}".format(member_list))
17+
logging.debug("old_member_list: {}".format(old_member_list))
1718
logging.debug("self_identity: {}".format(self_identity))
1819
if self_identity not in member_list:
1920
raise RuntimeError(
@@ -25,20 +26,8 @@ def hash_ip(ip):
2526

2627
hashed_member_dict = {hash_ip(m): m for m in member_list}
2728
hashed_member_list = sorted(hashed_member_dict.keys())
28-
29-
# To address issue on broadcast after rebuild
30-
# https://github.com/caicloud/ftlib/issues/51
31-
# Re-arrange the hashed_member_list
32-
candidate_idx = 1
33-
if hashed_member_list[0] not in old_member_list:
34-
assert len(old_member_list) > 0
35-
while candidate_idx < len(hashed_member_list):
36-
if hashed_member_list[candidate_idx] in old_member_list:
37-
break
38-
assert hashed_member_list[candidate_idx] in old_member_list
39-
temp = hashed_member_list[0]
40-
hashed_member_list[0] = hashed_member_list[candidate_idx]
41-
hashed_member_list[candidate_idx] = temp
29+
logging.debug(f"hashed_member_dict = {hashed_member_dict}")
30+
logging.debug(f"hashed_member_list = {hashed_member_list}")
4231

4332
return (
4433
hashed_member_list.index(hash_ip(self_identity)),

0 commit comments

Comments
 (0)