Skip to content

Unified Camera subclass #33

@jaredmejia

Description

@jaredmejia

With commit cfc2300 we now have both zed camera and realsense support. However, the two classes ZedCam https://github.com/AGI-Labs/manimo_dev/blob/cfc2300b1597c70efea0e28d5bf3c0facc2b32cd/manimo/sensors/zed_camera.py#L58 and RealSenseCam are identical https://github.com/AGI-Labs/manimo_dev/blob/cfc2300b1597c70efea0e28d5bf3c0facc2b32cd/manimo/sensors/real_sense_camera.py#L62 The only difference is the add_image function https://github.com/AGI-Labs/manimo_dev/blob/cfc2300b1597c70efea0e28d5bf3c0facc2b32cd/manimo/sensors/real_sense_camera.py#L98)that is called.

Can we unify this into a single Camera class where the particular version of add_image is determined by the camera_cfg?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions