Calibration Stage Fix for crashing testcases #3557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
commented
Nov 28, 2025
tokatoka
reviewed
Nov 28, 2025
| log::info!("Disabling crashing/timeouting testcase {id} during calibration"); | ||
| let insert_result = state | ||
| .current_testcase_mut()? | ||
| .try_add_metadata(DisabledInCalibrationStageMetadata); |
Member
There was a problem hiding this comment.
what is this metadata used for?
Member
Author
There was a problem hiding this comment.
Documentation why the testcase is disabled
Member
There was a problem hiding this comment.
but this metadata is never used
Member
Author
There was a problem hiding this comment.
It's used below?
Also it'll be on disk so the end user can see what's up
Member
Author
There was a problem hiding this comment.
Handling the Err(err) case implicitly uses the metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a todo and disables flakey testcases that somehow got into the corpus.
Checklist
./scripts/precommit.shand addressed all comments