Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate a scanning functionality to obtain the OOB invitation #20

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mbunwe-victor
Copy link
Collaborator

No description provided.

@Ogenbertrand
Copy link
Collaborator

Ogenbertrand commented Feb 6, 2025

I tried scanning from your branch, it isn't working, can you also check that please?

@Ogenbertrand
Copy link
Collaborator

I tested the scanner but still got errors, take a look:
Screenshot from 2025-02-07 09-27-35

Screenshot from 2025-02-07 09-27-12

@mbunwe-victor
Copy link
Collaborator Author

About the error you have after scanning the QR Code of the didcomm-mediator-rs, I feel like it is an internal issue cause I also have the issue but testing with a different Mediator it works well.

@Ogenbertrand
Copy link
Collaborator

About the error you have after scanning the QR Code of the didcomm-mediator-rs, I feel like it is an internal issue cause I also have the issue but testing with a different Mediator it works well.

Is it working with the mediator rootsid, cuz i am testing with the rootsid mediator?

@mbunwe-victor
Copy link
Collaborator Author

Yeah, for me it works with the RootsID DIDComm

@Ogenbertrand
Copy link
Collaborator

About the errors i pasted above, they still persist. I confirm that i have tested with 2 other mediators. Please look into them again.

…ice-layer-for-mediator-oob-inv-and-contact-exchange
@mbunwe-victor
Copy link
Collaborator Author

About the error we are getting after the scan, i realized the issue could be coming from the MediatorCoordnation.ts file because the Buffer.from method seem not to recognize the "base64url" encoding which we are using but rather it supports standard encoding like base64.

I suggest we convert the base64url string to a standard base64 string before encoding.
Also meaning that the call to the backend works but fails at this level.

@Ogenbertrand
Copy link
Collaborator

About the error we are getting after the scan, i realized the issue could be coming from the MediatorCoordnation.ts file because the Buffer.from method seem not to recognize the "base64url" encoding which we are using but rather it supports standard encoding like base64.

I suggest we convert the base64url string to a standard base64 string before encoding. Also meaning that the call to the backend works but fails at this level.

I don't think so @mbunwe-victor, find the examples when each of them are used below, and also i dont think that should be an issue, but nevertheless, i'll do the modifications and run the test, to see the result.
Base64 → Use when encoding general binary data (e.g., emails, storage, images in HTML).
Base64URL → Use when encoding data for URLs, JWTs, and APIs to avoid special character issues.

mbunwe-victor and others added 4 commits February 19, 2025 10:11
…ice-layer-for-mediator-oob-inv-and-contact-exchange
…e-part-that-integrates-with-the-service-layer-for-mediator-oob-inv-and-contact-exchange
…or-mediator-oob-inv-and-contact-exchange' of github.com:ADORSYS-GIS/wallet-vc into feat/9-fe-part-that-integrates-with-the-service-layer-for-mediator-oob-inv-and-contact-exchange
@Ogenbertrand
Copy link
Collaborator

Ogenbertrand commented Feb 19, 2025

So this is what i think we need to do, though its not precise in the tickets description.
We need the displayed data(e.g routing key) so that we'll send it to bob for messaging, so you'll update the backend by logging just the routing key and the display it in the frontend so that the user can copy it and send for messaging.

WDUT @IngridPuppet @hugoib ?

@IngridPuppet
Copy link
Collaborator

So this is what i think we need to do, though its not precise in the tickets description. We need the displayed data(e.g routing key) so that we'll send it to bob for messaging, so you'll update the backend by logging just the routing key and the display it in the frontend so that the user can copy it and send for messaging.

WDUT @IngridPuppet @hugoib ?

I thought it makes sense to reuse our QR code sharing view. did:peer addresses are definitely not user-friendly.

@Ogenbertrand
Copy link
Collaborator

So this is what i think we need to do, though its not precise in the tickets description. We need the displayed data(e.g routing key) so that we'll send it to bob for messaging, so you'll update the backend by logging just the routing key and the display it in the frontend so that the user can copy it and send for messaging.
WDUT @IngridPuppet @hugoib ?

I thought it makes sense to reuse our QR code sharing view. did:peer addresses are definitely not user-friendly.

Yes yes, this also best:
@mbunwe-victor please look into that too please.

@mbunwe-victor
Copy link
Collaborator Author

So about this discussion,

So this is what i think we need to do, though its not precise in the tickets description.
We need the displayed data(e.g routing key) so that we'll send it to bob for messaging, so you'll update the backend by logging just the routing key and the display it in the frontend so that the user can copy it and send for messaging.

i had this:
Screenshot from 2025-02-20 17-57-00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE part that integrates with the service layer for Mediator OOB inv and contact exchange)
3 participants