Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Didcomm message exchange backend in service layer structure #54

Open
hugoib opened this issue Dec 6, 2024 · 6 comments · May be fixed by #101
Open

Didcomm message exchange backend in service layer structure #54

hugoib opened this issue Dec 6, 2024 · 6 comments · May be fixed by #101
Assignees

Comments

@hugoib
Copy link
Collaborator

hugoib commented Dec 6, 2024

Implement this logic: https://github.com/ADORSYS-GIS/wallet-vc-libs/blob/main/docs/service-layer/other-events.md#retrieve-messages

@IngridPuppet
Copy link
Collaborator

I'm not sure where the pickup protocol will come into play, but it will. Here is the link to the spec: https://didcomm.org/messagepickup/3.0/.

@Ogenbertrand Ogenbertrand self-assigned this Jan 22, 2025
@Awambeng Awambeng removed their assignment Jan 22, 2025
@Ogenbertrand
Copy link
Collaborator

Working on this.

@Ogenbertrand Ogenbertrand removed their assignment Jan 23, 2025
@hugoib
Copy link
Collaborator Author

hugoib commented Jan 23, 2025

The difference between this ticket and #55

Is that this ticket will handle the BE part interaction with the mediator. Yes, the message pickup:

https://github.com/ADORSYS-GIS/wallet-vc-libs/tree/main/docs/service-layer#alice-checks-status-requests

Ticket 55 handles the communication between FE and BE. Once the messages are already inside the DB of the BE. Since we are implementing a polling structure, it has different calls.

@hugoib hugoib self-assigned this Jan 23, 2025
@hugoib
Copy link
Collaborator Author

hugoib commented Feb 6, 2025

Currently troubleshooting an error in which a did:peer is generated twice during the mediation coordination. After this wrongly double generation, the wrong one is stored on the storage.

This needs to be fixed in order to make the next needed calls.

@IngridPuppet
Copy link
Collaborator

Currently troubleshooting an error in which a did:peer is generated twice during the mediation coordination. After this wrongly double generation, the wrong one is stored on the storage.

I would not say the double generation is wrong, just that both aren't stored; unless you also plan to separate the keylist update step. Compare with RootsID's notebook for Alice:

alice_did_for_mediator = await create_peer_did(1,1)
...
alice_did_for_bob = await create_peer_did(1, 1, service_endpoint=[{"uri": mediator_routing_key}])

@hugoib
Copy link
Collaborator Author

hugoib commented Feb 18, 2025

This issue is originally composed of 3 calls:

  1. https://didcomm.org/messagepickup/3.0/status-request
  2. https://didcomm.org/messagepickup/3.0/delivery-request
  3. https://didcomm.org/messagepickup/3.0/messages-received

Call 1 and 2 are working on the playground of this commit:

76ada06

Next step, cleanups, add event layer and add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants