incorporate additional fixed information in fits header

[lspitler]

Call with additional fits header parameters that might be relevant information to the sequence being taken.

Maybe two types of meta information:

1. static, site specific information
2. dynamic, sequence specific information.

Example site parameters might include:

CAMERA_ID
FOCUSER_ID
SITE
SITE_TEMP

Example sequence parameters might include:

MOUNT_RA
MOUNT_DEC
MOUNT_ALT
MOUNT_AZ
AIRMASS
TARGET_NAME
FILTER

[lspitler]

I can do this but welcome input on best way to do this @MartinCupak

[MartinCupak]

For the comamndline tool, may be I would just copy these from the yaml config where it makes sense - eg Camera_ID, FOCUSER_ID, SITE - the script does not really deal with other things that ne ZWO camera (eg does not do pointing, control filters, and the only temperature it can read is from the camera itself.
All the bells and whistles will come when it gets integrated into POCS.

[lspitler]

As discussed, @MartinCupak we would like to do some observations with this code before the POCS integration is completed.

Do you have any suggestions on the best way to implement this feature? Should we pass it a yaml file with fits header keyword and value pairs?

[MartinCupak]

Yes, I would put the site/ID (constant) parameters to the yaml file. There already is "name" in device section, that could be the CAMERA_ID.
I have deliberately removed the focuser and filterwheel sections to keep the yaml as simple as possible. I would ad what you need here in this issue.

The commandline demo tool code keeps things simple as well.

Take the 1st camera device

device = devices[0]

get a parameter from device section

sn = device['serial_number']

for example to get
FOCUSER_ID
from ASI183MM_jetson005.yaml

cameras:
  devices:
    - name: "Huntsman_jetson005_ASI193MM"
      # 4656 x 3520
      serial_number: "2d194b0013090900"
      ...
      focuser:
        model: huntsman.pocs.focuser.birger.Focuser
        id: focuser_05
   ...

focuser = device.get('focuser', {})
focuser_model = focuser.get('model')
focuser_id = focuser.get('id')

[MartinCupak]

Not sure with the dynamic parameters. But if you call the pp_test.py script each time those change, it could be in the yaml as well.