Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use non-semver image tags #62

Open
dan-sullivan opened this issue Nov 26, 2023 · 1 comment
Open

Unable to use non-semver image tags #62

dan-sullivan opened this issue Nov 26, 2023 · 1 comment

Comments

@dan-sullivan
Copy link

Hi!
Due to the various semantic versioning checks for the image tags, you cannot use a non-semver compliant tag. Particularly Im trying to use the ai-beta tag.

e.g. this in deployments.yaml is a failure point.

          volumeMounts:
            - name: data
              mountPath: {{ if semverCompare ">=1.0" (.Values.image.tag | default .Chart.AppVersion) }}/home/node/.n8n{{ else }}/root/.n8n{{ end }}

And of course when attempting to deploy, this fails pointing out the tag isnt semver compliant. I realise these are non-production tags so would you be willing to support these?

@Vad1mo
Copy link
Member

Vad1mo commented Nov 26, 2023

Happy to accept PR. The suggest to ditch support for below version 1.0. we can bump the chart to 2.x and outline breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants