Removed pantry pod and codabled everything (#274)

* Removed pantry pod and codabled everything.

* Updated tests to run on xcode 11.

* More specific in our xcode build.

* Use the temp directory during tests.

* Less test configuration with tips from @subdigital

Author: nickoneill

.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_PATH: "vendor/bundle"

.circleci/config.yml

@@ -20,7 +20,7 @@ jobs:
     # The `macos` block requests that builds will run on a machine running
     # macOS with the specified version of Xcode installed
     macos:
-      xcode: '10.2.1'
+      xcode: '11.2.1'
     steps:
     # Machine Setup
     #   If you break your build into multiple jobs with workflows, you will probably want to do the parts of this that are relevant in each

.gitignore

@@ -68,3 +68,4 @@ fastlane/screenshots
 fastlane/test_output
 .env
 .ruby-version
+vendor/

FiveCalls/FiveCalls.xcodeproj/project.pbxproj

@@ -676,7 +676,7 @@
 				TargetAttributes = {
 					B502805A1E478BC200749ED7 = {
 						CreatedOnToolsVersion = 8.2.1;
-						DevelopmentTeam = C2K3864N2N;
+						DevelopmentTeam = 5A8RM3W5R7;
 						LastSwiftMigration = 0900;
 						ProvisioningStyle = Automatic;
 						TestTargetID = B52805101E3FA94D00EE832A;
@@ -808,12 +808,10 @@
 			);
 			inputPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-FiveCallsTests/Pods-FiveCallsTests-frameworks.sh",
-				"${BUILT_PRODUCTS_DIR}/Pantry/Pantry.framework",
 				"${BUILT_PRODUCTS_DIR}/R.swift.Library/Rswift.framework",
 			);
 			name = "[CP] Embed Pods Frameworks";
 			outputPaths = (
-				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Pantry.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Rswift.framework",
 			);
 			runOnlyForDeploymentPostprocessing = 0;
@@ -901,7 +899,6 @@
 				"${BUILT_PRODUCTS_DIR}/DZNEmptyDataSet/DZNEmptyDataSet.framework",
 				"${BUILT_PRODUCTS_DIR}/Down/Down.framework",
 				"${BUILT_PRODUCTS_DIR}/Kingfisher/Kingfisher.framework",
-				"${BUILT_PRODUCTS_DIR}/Pantry/Pantry.framework",
 				"${BUILT_PRODUCTS_DIR}/PromiseKit/PromiseKit.framework",
 				"${BUILT_PRODUCTS_DIR}/R.swift.Library/Rswift.framework",
 				"${BUILT_PRODUCTS_DIR}/SimpleKeychain/SimpleKeychain.framework",
@@ -913,7 +910,6 @@
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/DZNEmptyDataSet.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Down.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Kingfisher.framework",
-				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Pantry.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/PromiseKit.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Rswift.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/SimpleKeychain.framework",
@@ -1093,7 +1089,7 @@
 			baseConfigurationReference = FD64521687461F251492AC67 /* Pods-FiveCallsTests.debug.xcconfig */;
 			buildSettings = {
 				BUNDLE_LOADER = "$(TEST_HOST)";
-				DEVELOPMENT_TEAM = C2K3864N2N;
+				DEVELOPMENT_TEAM = 5A8RM3W5R7;
 				INFOPLIST_FILE = FiveCallsTests/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.2;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
@@ -1110,7 +1106,7 @@
 			baseConfigurationReference = 3974FAF60EF8B491496DC6D0 /* Pods-FiveCallsTests.release.xcconfig */;
 			buildSettings = {
 				BUNDLE_LOADER = "$(TEST_HOST)";
-				DEVELOPMENT_TEAM = C2K3864N2N;
+				DEVELOPMENT_TEAM = 5A8RM3W5R7;
 				INFOPLIST_FILE = FiveCallsTests/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.2;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
@@ -1250,6 +1246,7 @@
 				INFOPLIST_FILE = FiveCalls/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.2;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
+				MARKETING_VERSION = 1.6;
 				ONE_SIGNAL_APP_ID = "5fd4ca41-9f6c-4149-a312-ae3e71b35c0e";
 				PRODUCT_BUNDLE_IDENTIFIER = "org.fivecalls.FiveCalls-ios";
 				PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1278,6 +1275,7 @@
 				INFOPLIST_FILE = FiveCalls/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.2;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
+				MARKETING_VERSION = 1.6;
 				ONE_SIGNAL_APP_ID = "5fd4ca41-9f6c-4149-a312-ae3e71b35c0e";
 				PRODUCT_BUNDLE_IDENTIFIER = "org.fivecalls.FiveCalls-ios";
 				PRODUCT_NAME = "$(TARGET_NAME)";

FiveCalls/FiveCalls.xcodeproj/xcshareddata/xcschemes/FiveCalls.xcscheme

@@ -41,6 +41,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "B52805101E3FA94D00EE832A"
+            BuildableName = "FiveCalls.app"
+            BlueprintName = "FiveCalls"
+            ReferencedContainer = "container:FiveCalls.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -53,17 +62,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "B52805101E3FA94D00EE832A"
-            BuildableName = "FiveCalls.app"
-            BlueprintName = "FiveCalls"
-            ReferencedContainer = "container:FiveCalls.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -85,8 +83,6 @@
             ReferencedContainer = "container:FiveCalls.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

FiveCalls/FiveCalls/AppDelegate.swift

@@ -7,7 +7,6 @@
 //
 
 import UIKit
-import Pantry
 import Auth0
 import OneSignal
 
@@ -22,10 +21,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             resetData()
         }
 
-        migrateSavedData()
-
-        Pantry.useApplicationSupportDirectory = true
-
         clearNotificationBadge()
         setAppearance()
 
@@ -58,26 +53,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             OneSignal.inFocusDisplayType = OSNotificationDisplayType.notification
         }
     }
-
-    func migrateSavedData() {
-        let pantryDirName = "com.thatthinginswift.pantry"
-        // Pantry used to store data in the caches folder. If this exists, we need to move it
-        // and delete it, to avoid this getting purged when the device is low on disk space.
-        let cachesDir = NSSearchPathForDirectoriesInDomains(.cachesDirectory, .userDomainMask, true).first!
-        let oldPantryPath = URL(fileURLWithPath: cachesDir).appendingPathComponent(pantryDirName).path
-
-        if FileManager.default.fileExists(atPath: oldPantryPath) {
-            print("Saved data found in caches folder, moving to Application Support...")
-            let appSupportDir = NSSearchPathForDirectoriesInDomains(.applicationSupportDirectory, .userDomainMask, true).first!
-            let targetPath = URL(fileURLWithPath: appSupportDir).appendingPathComponent(pantryDirName).path
-            do {
-                try FileManager.default.moveItem(atPath: oldPantryPath, toPath: targetPath)
-                print("Files migrated.")
-            } catch let e {
-                print("Error moving files: \(e)")
-            }
-        }
-    }
 
     func transitionTo(rootViewController viewController: UIViewController) {
         guard let window = self.window else { return }
@@ -140,7 +115,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         UserDefaults.standard.removePersistentDomain(forName: appDomain)
 
         // clear any saved location data
-        Pantry.removeAllCache()
+        ContactLogs.removeData()
     }
 
     private func clearNotificationBadge() {
@@ -161,4 +136,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         defaults.setValue(currentVersion, forKey: UserDefaultsKey.appVersion.rawValue)
         defaults.set(Int(0), forKey: UserDefaultsKey.countOfCallsForRatingPrompt.rawValue)
     }
+
+    static var isRunningUnitTests: Bool {
+        return ProcessInfo.processInfo.environment.keys.contains("XCInjectBundleInto")
+    }
 }