Skip to content

Commit e78fab6

Browse files
committed
Updated coding standard, added new coding standard for TYPO3 v9
1 parent 5a5f029 commit e78fab6

File tree

3 files changed

+55
-0
lines changed

3 files changed

+55
-0
lines changed

ForwardMedia/ruleset.xml

+16
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,14 @@
4949
</properties>
5050
</rule>
5151

52+
<rule ref="SlevomatCodingStandard.Commenting.ForbiddenComments">
53+
<properties>
54+
<property name="forbiddenCommentPatterns" type="array">
55+
<element value="/^action ([^ ]+)$/" />
56+
</property>
57+
</properties>
58+
</rule>
59+
5260

5361
<rule ref="SlevomatCodingStandard.ControlStructures">
5462
<exclude name="SlevomatCodingStandard.ControlStructures.ControlStructureSpacing" />
@@ -120,6 +128,9 @@
120128

121129
<!-- Normally I would agree, but I like built-in names first (ZipArchive before user-land classes) -->
122130
<exclude name="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses" />
131+
132+
<!-- Model files are generated by extension_builder -->
133+
<exclude-pattern>*/Domain/Model/*.php</exclude-pattern>
123134
</rule>
124135
<rule ref="SlevomatCodingStandard.Namespaces.UnusedUses">
125136
<properties>
@@ -197,12 +208,17 @@
197208
<exclude name="VariableAnalysis.CodeAnalysis.VariableAnalysis.StaticOutsideClass" />
198209
</rule>
199210
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis">
211+
<severity>6</severity>
200212
<!-- $_EXTKEY is pre-defined -->
201213
<properties>
202214
<property name="validUndefinedVariableNames" value="_EXTKEY EM_CONF TYPO3_CONF_VARS" />
203215
</properties>
204216
</rule>
205217

218+
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.undefinedVariable">
219+
<severity>6</severity>
220+
</rule>
221+
206222
<!-- <rule ref="Generic.Arrays.DisallowLongArraySyntax" /> -->
207223
<!-- <rule ref="Generic.CodeAnalysis.EmptyStatement" /> -->
208224
<rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" />

ForwardMediaModern/ruleset.xml

+13
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,17 @@
2828

2929
<!-- Throwable only exists with PHP 7 -->
3030
<rule ref="SlevomatCodingStandard.Exceptions" />
31+
32+
<rule ref="SlevomatCodingStandard.Commenting.ForbiddenAnnotations">
33+
<properties>
34+
<property name="forbiddenAnnotations" type="array">
35+
<element value="@author" />
36+
<element value="@copyright" />
37+
<element value="@license" />
38+
<element value="@package" />
39+
<element value="@throws" />
40+
<element value="@version" />
41+
</property>
42+
</properties>
43+
</rule>
3144
</ruleset>

ForwardMediaTypo3v9/ruleset.xml

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<?xml version="1.0"?>
2+
<ruleset name="Forward">
3+
<description>PHP Coding Standard for FORWARD MEDIA TYPO3 v9 projects</description>
4+
5+
<rule ref="ForwardMediaModern" />
6+
7+
<rule ref="SlevomatCodingStandard.Commenting.ForbiddenAnnotations">
8+
<properties>
9+
<property name="forbiddenAnnotations" type="array">
10+
<element value="@author" />
11+
<element value="@copyright" />
12+
<element value="@license" />
13+
<element value="@package" />
14+
<element value="@throws" />
15+
<element value="@version" />
16+
17+
<element value="@cascade" />
18+
<element value="@ignorevalidation" />
19+
<element value="@inject" />
20+
<element value="@lazy" />
21+
<element value="@transient" />
22+
<element value="@validate" />
23+
</property>
24+
</properties>
25+
</rule>
26+
</ruleset>

0 commit comments

Comments
 (0)