Merge pull request #11 from Acring/fix/file-upload-timeout

4ier · web-flow · commit 3d0fb6b09643 · 2026-03-20T09:03:50.000+08:00
fix(client): increase timeout for file upload requests
diff --git a/internal/client/client.go b/internal/client/client.go
@@ -16,6 +16,7 @@ const (
 	BaseURL        = "https://api.notion.com"
 	NotionVersion  = "2022-06-28"
 	DefaultTimeout = 30 * time.Second
+	UploadTimeout  = 5 * time.Minute
 )
 
 type Client struct {
@@ -322,7 +323,10 @@ func (c *Client) UploadFileContent(uploadID, fileName, contentType string, fileB
 		fmt.Printf("→ POST %s (multipart, %d bytes)\n", url, body.Len())
 	}
 
+	origTimeout := c.httpClient.Timeout
+	c.httpClient.Timeout = UploadTimeout
 	resp, err := c.httpClient.Do(req)
+	c.httpClient.Timeout = origTimeout
 	if err != nil {
 		return nil, fmt.Errorf("upload request failed: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ const (`
`16`	`16`	`BaseURL = "https://api.notion.com"`
`17`	`17`	`NotionVersion = "2022-06-28"`
`18`	`18`	`DefaultTimeout = 30 * time.Second`
	`19`	`+ UploadTimeout = 5 * time.Minute`
`19`	`20`	`)`
`20`	`21`
`21`	`22`	`type Client struct {`
`@@ -322,7 +323,10 @@ func (c *Client) UploadFileContent(uploadID, fileName, contentType string, fileB`
`322`	`323`	`fmt.Printf("→ POST %s (multipart, %d bytes)\n", url, body.Len())`
`323`	`324`	`}`
`324`	`325`
	`326`	`+ origTimeout := c.httpClient.Timeout`
	`327`	`+ c.httpClient.Timeout = UploadTimeout`
`325`	`328`	`resp, err := c.httpClient.Do(req)`
	`329`	`+ c.httpClient.Timeout = origTimeout`
`326`	`330`	`if err != nil {`
`327`	`331`	`return nil, fmt.Errorf("upload request failed: %w", err)`
`328`	`332`	`}`