Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm "Download OSM data from a raw query" not available in processing modeler #474

Open
pathmapper opened this issue Aug 30, 2023 · 4 comments
Labels
bug An identified bug

Comments

@pathmapper
Copy link

What is the bug?

Algorithm "Download OSM data from a raw query" not available in processing modeler anymore, only the algs under Advanced are available.

This is because of

return QgisAlgorithm.flags(self) | QgsProcessingAlgorithm.FlagHideFromModeler

is this expected?

I think this alg was available in the past because I've got some old models using it :-)

grafik

grafik

Environment

  • QuickOSM version: 2.2.3
  • QGIS version: 3.30.2
  • OS: Windows 10
@pathmapper pathmapper added the bug An identified bug label Aug 30, 2023
@Gustry
Copy link
Member

Gustry commented Aug 30, 2023

Hum, I will look into it.

git blame tells me it likes this for at least 2 years minimum (July 2021). (creation of the file, but maybe it was legacy from a previous implementation)

But this algorithm "Download OSM data from raw query", isn't it two algorithm "Build raw query" and then send the output the native "native:filedownloader" algorithm ?

So, a long time ago... I will try to remember.

@pathmapper
Copy link
Author

pathmapper commented Aug 30, 2023

Thanks for looking into it @Gustry

Motivation to have it again available in the processing modeler:

  • easier to use and explain (no need to use native:filedownloader afterwards)
  • attribute value encoding is correct - with "Build raw query" + native:filedownloader I'm running into OSM name tag encoding #369
  • hstore field "other tags" seems already exploded
  • all in all same result as when using a raw query from plugin interface

@pathmapper
Copy link
Author

Maybe the reason not to show it were the side effects described in #362.

But can't spot anything in the changelog about the removal, so maybe it was unintentional.

@Gustry
Copy link
Member

Gustry commented Aug 30, 2023

#362 is from october 2021, git blame is at minimum July 2021. I will dig what has been done.

hstore field "other tags" seems already exploded

Indeed, it was like a package all inclusive : building query, encoding it, calling the native file download, then extracting data

I haven't been using QuickOSM for years now, so I don't remember the reason of the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An identified bug
Projects
None yet
Development

No branches or pull requests

2 participants