migrate.ts: SkillCourseID coudn't migrate properly

[arkitowho]

So this is a long time issue since courseid changed in kfc-6.0.3.7.
I've been test on 1.50c/1.50d+kfc-6.1.x/kfc-6.2.x/kfc-6.0.x/kfc-6.0.3.7, they got the same error. But if changed to kfc-6.0.3.6 then it work.

I added this to bypass the progress when it can not find proper IDs but will lose the Skill Analyzer data.

if(skillData && 'courses' in skillData) {

My data was created after kfc-6.0.3.7 so it dosen't have problem, but I test some data created before kfc-6.0.3.7 from other people, it will appear this error when you update to latest or some version after kfc-6.0.3.7.

In sometimes it will broke the savedata and fill the file with some label and savedata database will boom to like 20-60mb

[22vv0]

oh no, that's not supposed to happen. let me see what i can do.

[22vv0]

will apply your fix next time. looks like it happens when no course data was found for that specific sid and it doesn't check if skillData is undefined. honest oversight on my part.

if(skillData && 'courses' in skillData) {

not sure why you're getting flooded 6.66666666 cid course data. which version does this happen (on latest?) and which version did the savedata come from?

[arkitowho]

looks like 6.666666 cid will only apeared when you created data before kfc-6.0.3.6 then upgrade to any version after 6.0.3.6（savedata need SkillAnalyzer record）, but not sure is the plugin's problem or core's problem. I don't have enough sample to test now, will check again when it happend.

[SuomiKP31]

[unknown] error:
  [unknown] error: D:\MiscGames\KFC-2025120900\contents\plugins\sdvx@asphyxia\handlers\migrate.ts:34
        courseData.forEach(async course => {
            ^
  [unknown] error: TypeError: Cannot read properties of undefined (reading 'id')
    at D:\MiscGames\KFC-2025120900\contents\plugins\sdvx@asphyxia\handlers\migrate.ts:39:156
    at Array.forEach (<anonymous>)
    at updateSkillCourseIds (D:\MiscGames\KFC-2025120900\contents\plugins\sdvx@asphyxia\handlers\migrate.ts:34:13)
    at Object.dataUpdate (D:\MiscGames\KFC-2025120900\contents\plugins\sdvx@asphyxia\handlers\migrate.ts:26:2)

When migrating from 0527 to 1209, this error was triggered on a different line. It looks like skillData['courses'][courseIndex] can be undefined too.

You'll need
``` if(courseIndex === -1 && skillData['courses'][courseIndex]) ```
to bypass this.