Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/kubernetessecrets/kubernetes_secrets_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,8 @@ func BuildKubernetesSecretFromOnePasswordItem(
func BuildKubernetesSecretData(fields []model.ItemField, files []model.File) map[string][]byte {
secretData := map[string][]byte{}
for i := 0; i < len(fields); i++ {
if fields[i].Value != "" {
key := formatSecretDataName(fields[i].Label)
secretData[key] = []byte(fields[i].Value)
}
key := formatSecretDataName(fields[i].Label)
secretData[key] = []byte(fields[i].Value)
}

// populate unpopulated fields from files
Expand Down
32 changes: 32 additions & 0 deletions pkg/kubernetessecrets/kubernetes_secrets_builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,38 @@ func TestBuildKubernetesSecretData(t *testing.T) {
compareFields(fields, secretData, t)
}

func TestBuildKubernetesSecretDataWithEmptyValues(t *testing.T) {
fields := []model.ItemField{
{Label: "token", Value: "secret-token"},
{Label: "runner-token", Value: ""},
{Label: "another-field", Value: "value"},
{Label: "empty-field-2", Value: ""},
}

secretData := BuildKubernetesSecretData(fields, nil)

// Verify all fields are present, including empty ones
if len(secretData) != len(fields) {
t.Errorf("Expected %d fields, got %d", len(fields), len(secretData))
}

for _, field := range fields {
key := formatSecretDataName(field.Label)
value, exists := secretData[key]
if !exists {
t.Errorf("Field '%s' should be present in secret data", field.Label)
continue
}
if string(value) != field.Value {
t.Errorf("Field '%s': expected value '%s', got '%s'", field.Label, field.Value, string(value))
}
// Verify empty values are empty byte slices (not nil)
if field.Value == "" && len(value) != 0 {
t.Errorf("Empty field '%s' should have empty byte slice, got length %d", field.Label, len(value))
}
}
}

func TestBuildKubernetesSecretFromOnePasswordItem(t *testing.T) {
annotationKey := "annotationKey"
annotationValue := "annotationValue"
Expand Down