From e4bdd3bcb16373c3c581348b5eb15964fd5c9eac Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Thu, 5 Dec 2024 11:19:53 -0500 Subject: [PATCH 1/3] Update Chrome logging test to assert on all logs Previously ignored informational messages --- spec/support/capybara.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/support/capybara.rb b/spec/support/capybara.rb index 1bbb1cbd88c..f430359d3a2 100644 --- a/spec/support/capybara.rb +++ b/spec/support/capybara.rb @@ -14,6 +14,7 @@ options.add_argument('--no-sandbox') options.add_argument('--disable-dev-shm-usage') options.add_argument("--proxy-server=127.0.0.1:#{Capybara::Webmock.port_number}") + options.add_option('goog:loggingPrefs', { browser: 'ALL' }) Capybara::Selenium::Driver.new app, browser: :chrome, @@ -35,6 +36,7 @@ options.add_argument("--user-agent='#{user_agent_string}'") options.add_argument('--use-fake-device-for-media-stream') options.add_argument("--proxy-server=127.0.0.1:#{Capybara::Webmock.port_number}") + options.add_option('goog:loggingPrefs', { browser: 'ALL' }) Capybara::Selenium::Driver.new app, browser: :chrome, From 567094c0f0a60091f6eab8c0a3326b08f8ae0ba9 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Thu, 5 Dec 2024 11:20:22 -0500 Subject: [PATCH 2/3] Improve autocomplete compatibility for sign-in form User-Facing Enhancements, Sign-in, Improve autocomplete compatibility for sign-in form --- app/views/devise/sessions/new.html.erb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/views/devise/sessions/new.html.erb b/app/views/devise/sessions/new.html.erb index 46833389d09..b5d3dbbf05e 100644 --- a/app/views/devise/sessions/new.html.erb +++ b/app/views/devise/sessions/new.html.erb @@ -29,7 +29,10 @@ name: :email, label: t('account.index.email'), required: true, - input_html: { autocorrect: 'off' }, + input_html: { + autocomplete: 'username', + autocorrect: 'off', + }, ) %> <%= render PasswordToggleComponent.new( form: f, From 1bc33125e62beb12a3cff562ef88e4650043cf66 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Wed, 18 Dec 2024 10:35:11 -0500 Subject: [PATCH 3/3] Add autocomplete for SSN --- app/views/shared/_ssn_field.html.erb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/views/shared/_ssn_field.html.erb b/app/views/shared/_ssn_field.html.erb index f38d714f371..623c055e074 100644 --- a/app/views/shared/_ssn_field.html.erb +++ b/app/views/shared/_ssn_field.html.erb @@ -15,6 +15,12 @@ locals: required: true, pattern: '^\d{3}-?\d{2}-?\d{4}$', maxlength: 11, + # There is currently no appropriate autocomplete option for Social Security Number. Ongoing + # spec discussions may lead to a "national-identification-number" or equivalent, but this is + # not available at the time of writing. + # + # See: https://github.com/whatwg/html/issues/5740 + autocomplete: 'off', input_html: { class: 'ssn-toggle', value: f.object.ssn }, error_messages: { patternMismatch: t('idv.errors.pattern_mismatch.ssn') }, },