Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Case Issue week-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain #360

Open
uditrajput03 opened this issue Dec 14, 2023 · 1 comment
Open

Test Case Issue week-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain #360

uditrajput03 opened this issue Dec 14, 2023 · 1 comment

Comments

@uditrajput03
Copy link

Test cases runs synchronously instead of concurrently.
Which leads to execution time sum-ups and mostly test cases failed.
Screenshot 2023-12-15 at 2 36 41 AM

You can see the execution time which is close to expected.
But received time add ups and fails test cases
@uditrajput03
Copy link
Author

I solved it by using test.concurrent function in test file soon post PR

@uditrajput03 uditrajput03 changed the title week-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain Test Case Issueweek-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain Dec 14, 2023
@uditrajput03 uditrajput03 changed the title Test Case Issueweek-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain Test Case Issue week-2/01-async-js/tests/3-promise-all.test.js and 4- promise-chain Dec 14, 2023
@uditrajput03 uditrajput03 mentioned this issue Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed test cases for 3-promise-all and 4-promise-chain
1 participant
@uditrajput03