Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observer support for SMT #720

Open
0xaatif opened this issue Oct 13, 2024 · 0 comments
Open

observer support for SMT #720

0xaatif opened this issue Oct 13, 2024 · 0 comments
Labels
crate: trace_decoder Anything related to the trace_decoder crate. dev-exp developer experience enhancement New feature or request
Milestone
Testing and Valid...

Comments

@0xaatif
Copy link
Contributor

0xaatif commented Oct 13, 2024 •
edited
Loading

@atanmarko wrote this API for collecting diags through trace_decoder: https://github.com/0xPolygonZero/zk_evm/blob/a3f9a8dcd5744d141002222f62884b81109cabbf/trace_decoder/src/observer.rs

There is no handling for Observer<Type2World>, only Type1World:

zk_evm/trace_decoder/src/core.rs

Line 49 in a3f9a8d

observer: &mut impl Observer<Type1World>,

So we need refactoring to bring it up to speed. Ideally a prettier API too.
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Oct 13, 2024
@0xaatif 0xaatif added enhancement New feature or request crate: trace_decoder Anything related to the trace_decoder crate. dev-exp developer experience labels Nov 4, 2024
@0xaatif 0xaatif added this to the Testing and Validation milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate: trace_decoder Anything related to the trace_decoder crate. dev-exp developer experience enhancement New feature or request
Projects
Zero EVM
Status: Backlog
Milestone
Testing and Validation
Development

No branches or pull requests
1 participant
@0xaatif