Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly to Stable clarification #1638

Open
NikitaMasych opened this issue Nov 26, 2024 · 3 comments
Open

Nightly to Stable clarification #1638

NikitaMasych opened this issue Nov 26, 2024 · 3 comments

Comments

@NikitaMasych
Copy link
Contributor

NikitaMasych commented Nov 26, 2024

Hello guys!

I see that you rely on nightly rust, so I was wondering whether it is possible to patch the library with only degraded performance, but keeping security and all features working in order to switch to stable.

This is a rough patch of how I guess it should look.

@Nashtare
Copy link
Collaborator

Hi! This is something we've been slightly reluctant to do because of the expected performance downgrade (and given that the remaining unstable features are not that problematic (compared to the past usage of things like generic_const_exprs).

Would you happen to have benchmarked the difference from nightly to stable on either avx/neon?

@NikitaMasych
Copy link
Contributor Author

Got it. I have checked performance of simple factorial circuit from your examples in native rust and in wasm for both current version and my patch (stable) and there were no difference in efficiency of verification, that's all I can say

@Nashtare
Copy link
Collaborator

Interesting, feel free to open a PR then, we can do some more extensive benchmarking while reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants