Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect transaction jumps #1

Closed
4l0n50 opened this issue Dec 19, 2023 · 3 comments
Closed

Collect transaction jumps #1

4l0n50 opened this issue Dec 19, 2023 · 3 comments

Comments

@4l0n50
Copy link

4l0n50 commented Dec 19, 2023

Rationale

In order to improve the performance of jumpdest analysis during plonky2 evm witness generation, it is necessary to provide the list of all jump destinations with their respective contexts.

Implementation

It should involve storing the top of the stack when the program counter points to a JUMP, or storing the element below the top of the stack if the top of the stack is not equal to zero in a JUMPI, along with the current context.

@4l0n50 4l0n50 self-assigned this Dec 19, 2023
@Nashtare
Copy link

Hey @cffls! Friendly ping on this issue, do you think this is something we could see coming in the coming weeks? It'd be really nice if the prover didn't have to do all the JD analysis work on its own 🙂

@cffls
Copy link
Collaborator

cffls commented May 21, 2024

Hey @4l0n50 @Nashtare , this is something not traced in opcode tracer? If we want to include this in zero tracer, the trace output format might need to change quite a bit.

@Nashtare
Copy link

Moved to 0xPolygonZero/zk_evm#290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants